Page MenuHomePhabricator

[lldb] Fix bug in skipIfRosetta decorator

Authored by JDevlieghere on Aug 5 2020, 6:37 PM.



Currently, the skipIfRosetta decorator will skip tests with the message "not on macOS" on non-macOS platforms. This triggers for example when running tests remotely on device. Instead, it should only check the platform and architecture when running on the Darwin/macOS platform.

Diff Detail

Event Timeline

JDevlieghere requested review of this revision.Aug 5 2020, 6:37 PM
JDevlieghere created this revision.
JDevlieghere added inline comments.

Alternatively this could return None which means the test is not skipped.

davide accepted this revision.Aug 5 2020, 8:48 PM

yes, this makes sense. We could refine the check in future.

This revision is now accepted and ready to land.Aug 5 2020, 8:48 PM
This revision was automatically updated to reflect the committed changes.