[lldb] Fix bug in skipIfRosetta decorator

[JDevlieghere]

Summary

Currently, the skipIfRosetta decorator will skip tests with the message "not on macOS" on non-macOS platforms. This triggers for example when running tests remotely on device. Instead, it should only check the platform and architecture when running on the Darwin/macOS platform.

[JDevlieghere]

lldb/packages/Python/lldbsuite/test/decorators.py

542

Alternatively this could return None which means the test is not skipped.

[davide]

yes, this makes sense. We could refine the check in future.

[aprantl]

Thanks!

lldb/packages/Python/lldbsuite/test/decorators.py

def are_sb_headers_missing():
         return None
 
     return skipTestIfFn(are_sb_headers_missing)(func)
 
 
 def skipIfRosetta(bugnumber):
     """Skip a test when running the testsuite on macOS under the Rosetta translation layer."""
     def is_running_rosetta(self):
-        if not lldbplatformutil.getPlatform() in ['darwin', 'macosx']:
-            return "not on macOS"
+        if lldbplatformutil.getPlatform() in ['darwin', 'macosx']:
             if (platform.uname()[5] == "arm") and (self.getArchitecture() == "x86_64"):
                 return "skipped under Rosetta"
         return None
     return skipTestIfFn(is_running_rosetta)
 
 def skipIfiOSSimulator(func):
     """Decorate the item to skip tests that should be skipped on the iOS Simulator."""
     def is_ios_simulator():
         return "skip on the iOS Simulator" if configuration.lldb_platform_name == 'ios-simulator' else None
     return skipTestIfFn(is_ios_simulator)(func)