This is an archive of the discontinued LLVM Phabricator instance.

Paths

Refactor: Simplify boolean expressions in libclang
ClosedPublic

Authored by LegalizeAdulthood on Mar 22 2015, 1:32 PM.

Reviewers

Summary

Simplify boolean expresions using true and false with clang-tidy

LegalizeAdulthood retitled this revision from to Refactor: Simplify boolean expressions in libclang.

LegalizeAdulthood updated this object.

LegalizeAdulthood edited the test plan for this revision. (Show Details)

LegalizeAdulthood added a subscriber: Unknown Object (MLST).

LGTM.

This revision is now accepted and ready to land.Mar 22 2015, 5:02 PM

Could you commit this for me please? I do not have commit access. Thanks!

232996.

Path

Size

tools/

libclang/

2 lines

	Show First 20 Lines • Show All 1,712 Lines • ▼ Show 20 Lines
	public:			public:
	DeclVisit(const Decl *D, CXCursor parent, bool isFirst) :			DeclVisit(const Decl *D, CXCursor parent, bool isFirst) :
	VisitorJob(parent, VisitorJob::DeclVisitKind,			VisitorJob(parent, VisitorJob::DeclVisitKind,
	D, isFirst ? (void) 1 : (void) nullptr) {}			D, isFirst ? (void) 1 : (void) nullptr) {}
	static bool classof(const VisitorJob *VJ) {			static bool classof(const VisitorJob *VJ) {
	return VJ->getKind() == DeclVisitKind;			return VJ->getKind() == DeclVisitKind;
	}			}
	const Decl get() const { return static_cast<const Decl >(data[0]); }			const Decl get() const { return static_cast<const Decl >(data[0]); }
	bool isFirst() const { return data[1] ? true : false; }			bool isFirst() const { return data[1] != nullptr; }
	};			};
	class TypeLocVisit : public VisitorJob {			class TypeLocVisit : public VisitorJob {
	public:			public:
	TypeLocVisit(TypeLoc tl, CXCursor parent) :			TypeLocVisit(TypeLoc tl, CXCursor parent) :
	VisitorJob(parent, VisitorJob::TypeLocVisitKind,			VisitorJob(parent, VisitorJob::TypeLocVisitKind,
	tl.getType().getAsOpaquePtr(), tl.getOpaqueData()) {}			tl.getType().getAsOpaquePtr(), tl.getOpaqueData()) {}

	static bool classof(const VisitorJob *VJ) {			static bool classof(const VisitorJob *VJ) {
	▲ Show 20 Lines • Show All 5,571 Lines • Show Last 20 Lines