Page MenuHomePhabricator

[test] Support git commit version ids for clang.
ClosedPublic

Authored by rupprecht on Aug 4 2020, 2:14 PM.

Details

Summary

getCompilerVersion assumes that clang --version prints out a string like version [0-9\.]+.
If clang is built from trunk, the version line might look like clang version trunk (123abc).

Since there isn't any way of knowing by the commit id alone whether one commit is newer or older than another git commit (or clang version), assume that clang with a version id like this is very close to trunk. For example, any tests with @skipIf(compiler="clang", compiler_version=['<', '8']) should be run.

Diff Detail

Event Timeline

rupprecht created this revision.Aug 4 2020, 2:14 PM
Herald added a project: Restricted Project. · View Herald TranscriptAug 4 2020, 2:14 PM
rupprecht requested review of this revision.Aug 4 2020, 2:14 PM
MaskRay accepted this revision.Aug 4 2020, 2:24 PM
MaskRay added a subscriber: MaskRay.

Thanks!

This revision is now accepted and ready to land.Aug 4 2020, 2:24 PM
This revision was automatically updated to reflect the committed changes.