Page MenuHomePhabricator

[lldb] Enable std::pair in CxxModuleHandler
ClosedPublic

Authored by teemperor on Aug 3 2020, 10:01 AM.

Details

Summary

This adds support for substituting std::pair instantiations with enabled import-std-module.

With the fixes in parent revisions we can currently substitute a single pair (however, a result that
returns a second pair currently causes LLDB to crash while importing the second template
instantiation).

Diff Detail

Event Timeline

teemperor requested review of this revision.Aug 3 2020, 10:01 AM
teemperor created this revision.
aprantl accepted this revision.Aug 3 2020, 10:13 AM
aprantl added inline comments.
lldb/test/API/commands/expression/import-std-module/pair/TestPairFromStdModule.py
10

Does this cause any issues if the class name here is not unique?

This revision is now accepted and ready to land.Aug 3 2020, 10:13 AM

Do we understand how to fix the crash in the case where we get a pair back? I am not sure how frequent the use case is.

Do we understand how to fix the crash in the case where we get a pair back? I am not sure how frequent the use case is.

Haven't looked at that yet, but that's the next step :)

lldb/test/API/commands/expression/import-std-module/pair/TestPairFromStdModule.py
10

https://reviews.llvm.org/D83767 is actually there to address this (FWIW, we already have several 'TestCase' class names, so this isn't changing the situation regarding this).

This revision was automatically updated to reflect the committed changes.
Herald added a project: Restricted Project. · View Herald TranscriptSep 9 2020, 1:50 AM