This is an archive of the discontinued LLVM Phabricator instance.

Differential D85115

[update_cc_test_checks.py] Add test for D84511
ClosedPublic

Authored by arichardson on Aug 3 2020, 3:17 AM.

Details

Reviewers
MaskRay
Commits
rGe150d2cab868: [update_cc_test_checks.py] Add test for D84511

Diff Detail

Event Timeline

arichardson created this revision.Aug 3 2020, 3:17 AM
Herald added a project: Restricted Project. · View Herald TranscriptAug 3 2020, 3:17 AM
Herald added a subscriber: cfe-commits. · View Herald Transcript
arichardson requested review of this revision.Aug 3 2020, 3:17 AM
Harbormaster completed remote builds in B66745: Diff 282564.Aug 3 2020, 4:36 AM
MaskRay accepted this revision.Aug 3 2020, 8:14 AM
This revision is now accepted and ready to land.Aug 3 2020, 8:14 AM
Closed by commit rGe150d2cab868: [update_cc_test_checks.py] Add test for D84511 (authored by arichardson). · Explain WhyAug 6 2020, 1:17 AM
This revision was automatically updated to reflect the committed changes.
arichardson added a commit: rGe150d2cab868: [update_cc_test_checks.py] Add test for D84511.

Revision Contents

PathSize
clang/
test/
utils/
update_cc_test_checks/
3 lines
2 lines

Diff 283518

clang/test/utils/update_cc_test_checks/basic-cplusplus.test

## Test that CHECK lines are generated before the definion and not the declaration ## Test that CHECK lines are generated before the definion and not the declaration
# RUN: cp %S/Inputs/basic-cplusplus.cpp %t.cpp && %update_cc_test_checks %t.cpp # RUN: cp %S/Inputs/basic-cplusplus.cpp %t.cpp && %update_cc_test_checks %t.cpp
# RUN: diff -u %S/Inputs/basic-cplusplus.cpp.expected %t.cpp # RUN: diff -u %S/Inputs/basic-cplusplus.cpp.expected %t.cpp
## Check that it also works with the --llvm-bin flag instead of --clang
# RUN: cp %S/Inputs/basic-cplusplus.cpp %t.cpp && %update_cc_test_checks --clang='' --llvm-bin=%clang_tools_dir %t.cpp
# RUN: diff -u %S/Inputs/basic-cplusplus.cpp.expected %t.cpp
## Check that re-running update_cc_test_checks doesn't change the output ## Check that re-running update_cc_test_checks doesn't change the output
# RUN: %update_cc_test_checks %t.cpp # RUN: %update_cc_test_checks %t.cpp
# RUN: diff -u %S/Inputs/basic-cplusplus.cpp.expected %t.cpp # RUN: diff -u %S/Inputs/basic-cplusplus.cpp.expected %t.cpp

clang/test/utils/update_cc_test_checks/lit.local.cfg

Show All 17 Lines
extra_args += ' --opt ' + shell_quote(opt_path) extra_args += ' --opt ' + shell_quote(opt_path)
script_path = os.path.join(config.llvm_src_root, 'utils', script_path = os.path.join(config.llvm_src_root, 'utils',
'update_cc_test_checks.py') 'update_cc_test_checks.py')
assert os.path.isfile(script_path) assert os.path.isfile(script_path)
config.substitutions.append( config.substitutions.append(
('%update_cc_test_checks', "%s %s %s" % ( ('%update_cc_test_checks', "%s %s %s" % (
shell_quote(config.python_executable), shell_quote(script_path), shell_quote(config.python_executable), shell_quote(script_path),
extra_args))) extra_args)))
config.substitutions.append(
('%clang_tools_dir', shell_quote(config.clang_tools_dir)))