This is an archive of the discontinued LLVM Phabricator instance.

[lldb] Make Target::CleanupProcess consistent for breakpoints and watchpoints
Needs ReviewPublic

Authored by tatyana-krasnukha on Jul 30 2020, 10:48 AM.



Target clears watchpoints hit count but doesn't do the same for breakpoints. As was discussed in D84527, this behavior should be unified.

Now responsibility for cleanup lies on *List symmetrically for breakpoints and watchpoints.

The test case verifies that hit counts are reset to 0 after killing the process.

Diff Detail

Event Timeline

tatyana-krasnukha requested review of this revision.Jul 30 2020, 10:48 AM fails on the last check - it expects hit count to be saved after re-launching the process. Removed that check.