This is an archive of the discontinued LLVM Phabricator instance.

Differential D84953

[PGO][test] Add test to check memops changes function hash
ClosedPublic

Authored by hjyamauchi on Jul 30 2020, 10:22 AM.

Details

Reviewers
davidxl
Commits
rGdcdc77619e1a: [PGO][test] Add test to check memops changes function hash
Summary

Following up D84782.

Diff Detail

Event Timeline

hjyamauchi created this revision.Jul 30 2020, 10:22 AM
Herald added a project: Restricted Project. · View Herald TranscriptJul 30 2020, 10:22 AM
Herald added a subscriber: llvm-commits. · View Herald Transcript
hjyamauchi requested review of this revision.Jul 30 2020, 10:22 AM
Harbormaster completed remote builds in B66419: Diff 281971.Jul 30 2020, 10:40 AM
davidxl added a comment.Jul 30 2020, 10:48 AM

I think the test should use profile-gen option to compare generated hash of otherwise identical functions (except for memop).

hjyamauchi updated this revision to Diff 282003.Jul 30 2020, 11:33 AM

Address comment. Use -pgo-instr-gen.

hjyamauchi added a comment.Jul 30 2020, 11:33 AM
In D84953#2185239, @davidxl wrote:

I think the test should use profile-gen option to compare generated hash of otherwise identical functions (except for memop).

Done.

davidxl accepted this revision.Jul 30 2020, 11:38 AM

lgtm

This revision is now accepted and ready to land.Jul 30 2020, 11:38 AM
Harbormaster completed remote builds in B66438: Diff 282003.Jul 30 2020, 12:04 PM
This revision was landed with ongoing or failed builds.Jul 31 2020, 9:43 AM
Closed by commit rGdcdc77619e1a: [PGO][test] Add test to check memops changes function hash (authored by hjyamauchi). · Explain Why
This revision was automatically updated to reflect the committed changes.
hjyamauchi added a commit: rGdcdc77619e1a: [PGO][test] Add test to check memops changes function hash.

Revision Contents

PathSize
llvm/
test/
Transforms/
PGOProfile/
25 lines

Diff 282251

llvm/test/Transforms/PGOProfile/memop_hash.ll

  • This file was added.
; RUN: opt < %s -pgo-instr-gen -S | FileCheck %s
; RUN: opt < %s -passes=pgo-instr-gen -S | FileCheck %s
target datalayout = "e-m:e-p270:32:32-p271:32:32-p272:64:64-i64:64-f80:128-n8:16:32:64-S128"
target triple = "x86_64-unknown-linux-gnu"
declare void @llvm.memcpy.p0i8.p0i8.i32(i8* nocapture writeonly, i8* nocapture readonly, i32, i1)
define i64 @foo1(i8* %a, i8* %b, i32 %s) {
entry:
call void @llvm.memcpy.p0i8.p0i8.i32(i8* %a, i8* %b, i32 %s, i1 false);
ret i64 0
}
define i64 @foo2(i8* %a, i8* %b, i32 %s) {
entry:
ret i64 0
}
; The two hashes should not be equal as the existence of the memcpy should change the hash.
;
; CHECK: @foo1
; CHECK: call void @llvm.instrprof.increment(i8* getelementptr inbounds ([4 x i8], [4 x i8]* @__profn_foo1, i32 0, i32 0), i64 [[FOO1_HASH:[0-9]+]], i32 1, i32 0)
; CHECK: @foo2
; CHECK-NOT: call void @llvm.instrprof.increment(i8* getelementptr inbounds ([4 x i8], [4 x i8]* @__profn_foo2, i32 0, i32 0), i64 [[FOO1_HASH]], i32 1, i32 0)