Page MenuHomePhabricator

Add support for CLI commands in lldb-mi
ClosedPublic

Authored by ki.stfu on Mar 20 2015, 8:23 AM.

Details

Summary

This patch adds support for CLI command in lldb-mi. It's useful ability which also was implemented in gdb.

All tests pass on OS X.

Diff Detail

Event Timeline

ki.stfu updated this revision to Diff 22348.Mar 20 2015, 8:23 AM
ki.stfu retitled this revision from to Add support for CLI commands in lldb-mi.
ki.stfu updated this object.
ki.stfu edited the test plan for this revision. (Show Details)
ki.stfu added reviewers: abidh, clayborg, ted.
ki.stfu added subscribers: abidh, clayborg, ted, Unknown Object (MLST).

I have no problem with supporting CLI commands, but given that lldb & gdb have very different command syntaxes, it doesn't seem very useful to do this unless you have some way to tell your clients that they are typing lldb and not gdb commands. I'm not opposing this patch, but you really need to add something to the MI capability command to say you are lldb not gdb...

Friendly ping.

clayborg accepted this revision.Mar 24 2015, 9:40 AM
clayborg edited edge metadata.

lgtm

This revision is now accepted and ready to land.Mar 24 2015, 9:40 AM
abidh accepted this revision.Mar 24 2015, 10:08 AM
abidh edited edge metadata.

Looks ok.

ki.stfu closed this revision.Mar 24 2015, 2:02 PM