This is an archive of the discontinued LLVM Phabricator instance.

[lldb] Change the definition of ANSI_UNFAINT
ClosedPublic

Authored by gedatsu217 on Jul 27 2020, 12:20 PM.

Download Raw Diff

Details

Reviewers

labath
teemperor
JDevlieghere

Commits

rG5608f28f5527: [lldb] Change the definition of ANSI_UNFAINT

Summary

Change the definition of ANSI_UNFAINT in Editline.cpp.

Diff Detail

Repository: rG LLVM Github Monorepo

Event Timeline

gedatsu217 created this revision.Jul 27 2020, 12:20 PM

gedatsu217 added a child revision: D81001: [lldb] Display autosuggestion part in gray if there is one possible suggestion .Jul 27 2020, 12:27 PM

The change looks good with a few comments added.

lldb/source/Host/common/Editline.cpp
51	Please add a comment above referring to https://www.ecma-international.org/publications/files/ECMA-ST/Ecma-048.pdf
52	Please add a comment above: /// Faint, decreased intensity or second colour.
53	Please add a comment above: /// Normal colour or normal intensity (neither bold nor faint).

This revision is now accepted and ready to land.Jul 27 2020, 4:37 PM

labath accepted this revision.Jul 28 2020, 4:37 AM

Add explanations.

JDevlieghere added inline comments.Jul 28 2020, 9:58 AM

lldb/source/Host/common/Editline.cpp
51	I'm not sure what this comment means. I'd just like to have a comment (for the whole block) to the standard's PDF like so: /// https://www.ecma-international.org/publications/files/ECMA-ST/Ecma-048.pdf

Sorry, I misunderstood it.

In D84695#2179279, @gedatsu217 wrote:

Sorry, I misunderstood it.

No worries. This looks perfect, thank you.

Do you want me to land this for you?

I do not know how to land this. So, I would like to land this if I can do.

Closed by commit rG5608f28f5527: [lldb] Change the definition of ANSI_UNFAINT (authored by gedatsu217, committed by JDevlieghere). · Explain WhyJul 28 2020, 11:06 AM

This revision was automatically updated to reflect the committed changes.

JDevlieghere added a commit: rG5608f28f5527: [lldb] Change the definition of ANSI_UNFAINT.

Herald added a project: Restricted Project. · View Herald TranscriptJul 28 2020, 11:06 AM

Herald added a subscriber: lldb-commits. · View Herald Transcript

Revision Contents

Path

Size

lldb/

source/

Host/

common/

Editline.cpp

5 lines

Diff 281298

lldb/source/Host/common/Editline.cpp

	Show First 20 Lines • Show All 42 Lines • ▼ Show 20 Lines
	#endif			#endif

	// Editline uses careful cursor management to achieve the illusion of editing a			// Editline uses careful cursor management to achieve the illusion of editing a
	// multi-line block of text with a single line editor. Preserving this			// multi-line block of text with a single line editor. Preserving this
	// illusion requires fairly careful management of cursor state. Read and			// illusion requires fairly careful management of cursor state. Read and
	// understand the relationship between DisplayInput(), MoveCursor(),			// understand the relationship between DisplayInput(), MoveCursor(),
	// SetCurrentLine(), and SaveEditedLine() before making changes.			// SetCurrentLine(), and SaveEditedLine() before making changes.

				/// https://www.ecma-international.org/publications/files/ECMA-ST/Ecma-048.pdf
				JDevlieghereUnsubmitted Not Done Reply Inline Actions I'm not sure what this comment means. I'd just like to have a comment (for the whole block) to the standard's PDF like so: /// https://www.ecma-international.org/publications/files/ECMA-ST/Ecma-048.pdf JDevlieghere: I'm not sure what this comment means. I'd just like to have a comment (for the whole block) to…
	#define ESCAPE "\x1b"			#define ESCAPE "\x1b"
	JDevlieghereUnsubmitted Not Done Reply Inline Actions Please add a comment above referring to https://www.ecma-international.org/publications/files/ECMA-ST/Ecma-048.pdf JDevlieghere: Please add a comment above referring to https://www.ecma-international.
				/// Faint, decreased intensity or second colour.
	#define ANSI_FAINT ESCAPE "[2m"			#define ANSI_FAINT ESCAPE "[2m"
	JDevlieghereUnsubmitted Not Done Reply Inline Actions Please add a comment above: /// Faint, decreased intensity or second colour. JDevlieghere: Please add a comment above: ``` /// Faint, decreased intensity or second colour. ```
	#define ANSI_UNFAINT ESCAPE "[22m"			/// Normal colour or normal intensity (neither bold nor faint).
	JDevlieghereUnsubmitted Not Done Reply Inline Actions Please add a comment above: /// Normal colour or normal intensity (neither bold nor faint). JDevlieghere: Please add a comment above: ``` /// Normal colour or normal intensity (neither bold nor faint).
				#define ANSI_UNFAINT ESCAPE "[0m"
	#define ANSI_CLEAR_BELOW ESCAPE "[J"			#define ANSI_CLEAR_BELOW ESCAPE "[J"
	#define ANSI_CLEAR_RIGHT ESCAPE "[K"			#define ANSI_CLEAR_RIGHT ESCAPE "[K"
	#define ANSI_SET_COLUMN_N ESCAPE "[%dG"			#define ANSI_SET_COLUMN_N ESCAPE "[%dG"
	#define ANSI_UP_N_ROWS ESCAPE "[%dA"			#define ANSI_UP_N_ROWS ESCAPE "[%dA"
	#define ANSI_DOWN_N_ROWS ESCAPE "[%dB"			#define ANSI_DOWN_N_ROWS ESCAPE "[%dB"

	#if LLDB_EDITLINE_USE_WCHAR			#if LLDB_EDITLINE_USE_WCHAR

	▲ Show 20 Lines • Show All 1,451 Lines • Show Last 20 Lines