Page MenuHomePhabricator

[lldb] Change the definition of ANSI_UNFAINT
ClosedPublic

Authored by gedatsu217 on Jul 27 2020, 12:20 PM.

Details

Summary

Change the definition of ANSI_UNFAINT in Editline.cpp.

Diff Detail

Event Timeline

gedatsu217 created this revision.Jul 27 2020, 12:20 PM
JDevlieghere accepted this revision.Jul 27 2020, 4:37 PM

The change looks good with a few comments added.

lldb/source/Host/common/Editline.cpp
51
52

Please add a comment above:

/// Faint, decreased intensity or second colour.
53

Please add a comment above:

/// Normal colour or normal intensity (neither bold nor faint).
This revision is now accepted and ready to land.Jul 27 2020, 4:37 PM
labath accepted this revision.Jul 28 2020, 4:37 AM

Add explanations.

JDevlieghere added inline comments.Jul 28 2020, 9:58 AM
lldb/source/Host/common/Editline.cpp
51

I'm not sure what this comment means. I'd just like to have a comment (for the whole block) to the standard's PDF like so:

/// https://www.ecma-international.org/publications/files/ECMA-ST/Ecma-048.pdf

Sorry, I misunderstood it.

JDevlieghere accepted this revision.Jul 28 2020, 10:53 AM

Sorry, I misunderstood it.

No worries. This looks perfect, thank you.

Do you want me to land this for you?

I do not know how to land this. So, I would like to land this if I can do.

This revision was automatically updated to reflect the committed changes.
Herald added a project: Restricted Project. · View Herald TranscriptJul 28 2020, 11:06 AM