Page MenuHomePhabricator

debugserver: Support ios simulator load command disambiguation in qProcessInfo
ClosedPublic

Authored by aprantl on Jul 23 2020, 6:01 PM.

Details

Summary

This patch basically moves the disambiguation code from a place where it was complicated to implement straight to where the load command is parsed, which has the neat side affect of actually supporting all call sites!

rdar://problem/66011909

Diff Detail

Event Timeline

aprantl created this revision.Jul 23 2020, 6:01 PM
aprantl updated this revision to Diff 280307.Jul 23 2020, 6:09 PM

Update comment. I wonder if it is feasible to give the macCatalyst code the same treatment. It's more tricky because supporting zippered objects would force some additional state into the function.

friss accepted this revision.Jul 23 2020, 8:21 PM

LGTM!

lldb/tools/debugserver/source/DNB.cpp
1396–1399

s/doesn't/isn't/ ?

lldb/tools/debugserver/source/MacOSX/MachProcess.mm
782–783

I guess at this point we were really sure it was maybe a simulator :-)

This revision is now accepted and ready to land.Jul 23 2020, 8:21 PM
This revision was automatically updated to reflect the committed changes.
Herald added a project: Restricted Project. · View Herald TranscriptJul 24 2020, 9:52 AM