This is an archive of the discontinued LLVM Phabricator instance.

[mips][microMIPSr6] Implement ALUIPC and AUIPC instructions
ClosedPublic

Authored by jkolek on Mar 19 2015, 9:17 AM.

Diff Detail

Event Timeline

jkolek updated this revision to Diff 22261.Mar 19 2015, 9:17 AM
jkolek retitled this revision from to [mips][microMIPSr6] Implement ALUIPC and AUIPC instructions.
jkolek updated this object.
jkolek edited the test plan for this revision. (Show Details)
jkolek added reviewers: dsanders, zoran.jovanovic.
jkolek added subscribers: Unknown Object (MLST), petarj.
jkolek updated this revision to Diff 23061.Apr 1 2015, 8:54 AM
jkolek updated this revision to Diff 23215.Apr 3 2015, 5:02 AM
jkolek updated this revision to Diff 25170.May 7 2015, 5:46 AM
dsanders accepted this revision.May 8 2015, 3:39 AM
dsanders edited edge metadata.

LGTM with a nit

test/MC/Disassembler/Mips/micromips32r6.txt
12–17

Nit: Please use the single-line style.

Could you also fix the ones that have been committed in the multi-line style and delete the blank lines in a follow-up commit? No need for a review on that style correction commit

This revision is now accepted and ready to land.May 8 2015, 3:39 AM
jkolek updated this revision to Diff 25328.May 8 2015, 7:05 AM
jkolek edited edge metadata.
This revision was automatically updated to reflect the committed changes.