Page MenuHomePhabricator

[lldb] Cleanup CommandObject registration (NFC)
ClosedPublic

Authored by JDevlieghere on Jul 22 2020, 9:33 AM.

Details

Summary
  • Remove the spurious argument to CommandObjectScript
  • Use make_shared instead of bare new.
  • Hide code duplication behind a macro.

Diff Detail

Event Timeline

JDevlieghere created this revision.Jul 22 2020, 9:33 AM
mib accepted this revision.Jul 22 2020, 9:46 AM

I find the macro cleaner than my changes in D84305. LGTM!

This revision is now accepted and ready to land.Jul 22 2020, 9:46 AM
This revision was automatically updated to reflect the committed changes.
Herald added a project: Restricted Project. · View Herald TranscriptJul 22 2020, 9:52 AM