This is an archive of the discontinued LLVM Phabricator instance.

Differential D84274

Fixed move constructor of MMI to move MachineFunctions map
ClosedPublic

Authored by sridhar_gopinath on Jul 21 2020, 3:45 PM.

Details

Reviewers
bogner
Commits
rG4b5412b5dbc8: Fix the move constructor of MMI to move MachineFunctions map
Summary

The move constructor of MachineModuleInfo currently does not copy the MachineFunctions map. This commit fixes this issue.

Diff Detail

Event Timeline

sridhar_gopinath created this revision.Jul 21 2020, 3:45 PM
Herald added a project: Restricted Project. · View Herald TranscriptJul 21 2020, 3:45 PM
Herald added subscribers: llvm-commits, hiraditya. · View Herald Transcript
sridhar_gopinath added a reviewer: bogner.Jul 21 2020, 3:46 PM
Harbormaster completed remote builds in B65152: Diff 279645.Jul 21 2020, 4:17 PM
bogner accepted this revision.Jul 22 2020, 9:52 AM

LGTM. Do you need me to commit this for you?

This revision is now accepted and ready to land.Jul 22 2020, 9:52 AM
Closed by commit rG4b5412b5dbc8: Fix the move constructor of MMI to move MachineFunctions map (authored by sridhar_gopinath, committed by bogner). · Explain WhyJul 27 2020, 2:10 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents

PathSize
llvm/
lib/
CodeGen/
3 lines

Diff 281054

llvm/lib/CodeGen/MachineModuleInfo.cpp

Show First 20 Lines • Show All 172 Lines • ▼ Show 20 Linesvoid MachineModuleInfo::finalize() {
delete ObjFileMMI; delete ObjFileMMI;
ObjFileMMI = nullptr; ObjFileMMI = nullptr;
} }
MachineModuleInfo::MachineModuleInfo(MachineModuleInfo &&MMI) MachineModuleInfo::MachineModuleInfo(MachineModuleInfo &&MMI)
: TM(std::move(MMI.TM)), : TM(std::move(MMI.TM)),
Context(MMI.TM.getMCAsmInfo(), MMI.TM.getMCRegisterInfo(), Context(MMI.TM.getMCAsmInfo(), MMI.TM.getMCRegisterInfo(),
MMI.TM.getObjFileLowering(), nullptr, nullptr, false) { MMI.TM.getObjFileLowering(), nullptr, nullptr, false),
MachineFunctions(std::move(MMI.MachineFunctions)) {
ObjFileMMI = MMI.ObjFileMMI; ObjFileMMI = MMI.ObjFileMMI;
CurCallSite = MMI.CurCallSite; CurCallSite = MMI.CurCallSite;
UsesMSVCFloatingPoint = MMI.UsesMSVCFloatingPoint; UsesMSVCFloatingPoint = MMI.UsesMSVCFloatingPoint;
UsesMorestackAddr = MMI.UsesMorestackAddr; UsesMorestackAddr = MMI.UsesMorestackAddr;
HasSplitStack = MMI.HasSplitStack; HasSplitStack = MMI.HasSplitStack;
HasNosplitStack = MMI.HasNosplitStack; HasNosplitStack = MMI.HasNosplitStack;
AddrLabelSymbols = MMI.AddrLabelSymbols; AddrLabelSymbols = MMI.AddrLabelSymbols;
TheModule = MMI.TheModule; TheModule = MMI.TheModule;
▲ Show 20 Lines • Show All 134 Lines • Show Last 20 Lines