Page MenuHomePhabricator

[lldb/ObjectFileMachO] Correctly account for resolver symbols
ClosedPublic

Authored by friss on Jul 17 2020, 6:00 PM.

Details

Summary

The resolver addresses stored in the dyld trie are relative to the base
of the __TEXT segment. This is usually 0 in a dylib, so this was never
noticed, but it is not 0 for most dylibs integrated in the shared cache.
As we started using the shared cache images recently as symbol source,
this causes LLDB to fail to resolve symbols which go through a runtime
resolver.

Diff Detail

Event Timeline

friss created this revision.Jul 17 2020, 6:00 PM
Herald added a project: Restricted Project. · View Herald TranscriptJul 17 2020, 6:00 PM
jingham accepted this revision.Jul 17 2020, 6:09 PM

LGTM.

This revision is now accepted and ready to land.Jul 17 2020, 6:09 PM
This revision was automatically updated to reflect the committed changes.