[lldb] Make socket_packet_pump.py work in Python3

[teemperor]

Summary

The string_escape encoding used here was removed in Python 3 which makes the test crash during tearDown:

  File "/Users/teemperor/3llvm/llvm-project/lldb/third_party/Python/module/unittest2/unittest2/case.py", line 386, in run
    self.tearDown()
  File "/Users/teemperor/3llvm/llvm-project/lldb/packages/Python/lldbsuite/test/tools/lldb-server/gdbremote_testcase.py", line 124, in tearDown
    self._pump_queues.verify_queues_empty()
  File "/Users/teemperor/3llvm/llvm-project/lldb/packages/Python/lldbsuite/test/tools/lldb-server/socket_packet_pump.py", line 55, in verify_queues_empty
    _dump_queue(self.packet_queue())
  File "/Users/teemperor/3llvm/llvm-project/lldb/packages/Python/lldbsuite/test/tools/lldb-server/socket_packet_pump.py", line 28, in _dump_queue
    print(codecs.encode(the_queue.get(True), "string_escape"))
LookupError: unknown encoding: string_escape

Just replace it with repr which should work in both Python versions.

[labath]

How about print(repr(foo))? That should do something reasonable everywhere...

[teemperor]

• Moved to repr.

[teemperor]

Yeah repr also does the trick of escaping the null bytes.

lldb/packages/Python/lldbsuite/test/tools/lldb-server/socket_packet_pump.py

 
 from __future__ import print_function
 
 
 import re
 import select
 import threading
 import traceback
 import codecs
+import sys
 
 from six.moves import queue
 from lldbsuite.support import seven
 
 
 def _handle_output_packet_string(packet_contents):
     if (not packet_contents) or (len(packet_contents) < 1):
         return None
     elif packet_contents[0] != "O":
         return None
     elif packet_contents == "OK":
         return None
     else:
         return seven.unhexlify(packet_contents[1:])
 
 
 def _dump_queue(the_queue):
     while not the_queue.empty():
+        # 'string_escape' is only avilable in Python 2.
+        if sys.version_info.major == 2:
             print(codecs.encode(the_queue.get(True), "string_escape"))
+        else:
+            print(codecs.encode(the_queue.get(True), "unicode_escape"))
         print("\n")
 
 
 class PumpQueues(object):
 
     def __init__(self):
         self._output_queue = queue.Queue()
         self._packet_queue = queue.Queue()