This is an archive of the discontinued LLVM Phabricator instance.

[InstCombine] Fix typo in comment.
ClosedPublic

Authored by xinan-jiang on Jul 16 2020, 7:17 AM.

Diff Detail

Event Timeline

xinan-jiang created this revision.Jul 16 2020, 7:17 AM
Herald added a project: Restricted Project. · View Herald TranscriptJul 16 2020, 7:17 AM
fhahn accepted this revision.Jul 16 2020, 9:32 AM
fhahn added a subscriber: fhahn.

LGTM, thanks. It might be good to add a more descriptive title, e.g. something like [InstCombine] Fix typo in comment.

Please let me know if you need someone to land your patch,.

This revision is now accepted and ready to land.Jul 16 2020, 9:32 AM
xinan-jiang closed this revision.EditedJul 17 2020, 6:50 AM

It seems I could not push it to github. could you help to land it?

git push https://github.com/llvm/llvm-project.git HEAD:master
remote: Permission to llvm/llvm-project.git denied to xinan-jiang.

xinan-jiang retitled this revision from fit typo to [InstCombine] Fix typo in comment..Jul 17 2020, 6:54 AM
fhahn added a comment.Jul 17 2020, 6:55 AM

git push https://github.com/llvm/llvm-project.git HEAD:master
remote: Permission to llvm/llvm-project.git denied to xinan-jiang.

Right, it looks like you don't have permissions to push yet. For more details on how to request commit access after you submitted a few patches, see https://llvm.org/docs/DeveloperPolicy.html#obtaining-commit-access

In the meantime I can commit the patch on your behalf (https://llvm.org/docs/Phabricator.html#committing-someone-s-change-from-phabricator). If you want me to do so, please let me know the name & email I should use to set the author in the commit.

Author: Xinan Jiang <xinan.jxn@gmail.com>

Thanks.