Details
- Reviewers
fhahn - Commits
- rGd8e0baf29daa: [InstCombine] Fix typo in comment.
Diff Detail
- Repository
- rG LLVM Github Monorepo
Event Timeline
LGTM, thanks. It might be good to add a more descriptive title, e.g. something like [InstCombine] Fix typo in comment.
Please let me know if you need someone to land your patch,.
It seems I could not push it to github. could you help to land it?
git push https://github.com/llvm/llvm-project.git HEAD:master
remote: Permission to llvm/llvm-project.git denied to xinan-jiang.
Right, it looks like you don't have permissions to push yet. For more details on how to request commit access after you submitted a few patches, see https://llvm.org/docs/DeveloperPolicy.html#obtaining-commit-access
In the meantime I can commit the patch on your behalf (https://llvm.org/docs/Phabricator.html#committing-someone-s-change-from-phabricator). If you want me to do so, please let me know the name & email I should use to set the author in the commit.