This is an archive of the discontinued LLVM Phabricator instance.

[lldb] Print the exception traceback when hitting cleanup errors
ClosedPublic

Authored by teemperor on Jul 15 2020, 7:25 AM.

Details

Summary

Right now if the test suite encounters a cleanup error it just prints "CLEANUP ERROR:" but not any additional information.

This patch just prints the exception that caused the cleanup error. This should make debugging the failing tests
for D83865 easier (and seems in general nice to have).

Diff Detail

Event Timeline

teemperor created this revision.Jul 15 2020, 7:25 AM
teemperor edited the summary of this revision. (Show Details)Jul 15 2020, 7:26 AM
labath accepted this revision.Jul 15 2020, 7:26 AM

sounds like a good idea

This revision is now accepted and ready to land.Jul 15 2020, 7:26 AM

Can we pass the backtrace to the EventBuilder and set it as event["issue_backtrace"] like we do for event_for_job_test_add_error?

event_for_job_test_add_error was removed, so I'll go ahead and land this

Herald added a project: Restricted Project. · View Herald TranscriptAug 17 2020, 12:54 AM