This is an archive of the discontinued LLVM Phabricator instance.

Differential D83747

[argprom] Assessing impact of magic value MaxElements promoted on compiler performance
AbandonedPublic

Authored by teamiceberg on Jul 13 2020, 10:40 PM.

Details

Reviewers
jdoerfert
Summary

Our initial hypothesis is that changes to the magic value of (unsigned) MaxElements variable in ArgumentPromotion.cpp/ArgumentPromotion.h file can
lead to changes in compiler performance. To assess such changes, we have to introduce a global variable in the ArgumentPromotion.h header file. Then, we supply different values for this global variable by having a command line flag (-numargspromoted) bound to this global variable via the cl::opt interface. Initial analysis of compiler performance using the built in test suite demonstrate some significant changes in compile time as well as run time.
However, we are in the process of validating if these changes are real or just noise induced by other means. More experiments and sample runs need to be run, to be sure. However, we are setting up this initial patch as a way to learn how to setup a pipeline to enable the use of global variables to simulate magic values. Also, we are designing LIT tests to ensure that we submit a patch that conforms to built-in argument promotion tests in llvm/test folder.
Regression Test Setup: /llvm/test/Transforms/ArgumentPromotion has 3 tests written by me a) fourmember-struct-promote-ZERO.ll; b)fourmember-struct-promote-DEFAULT.ll ; c) fourmember-struct-promote-INTMAX.ll to demonstrate that the flag works successfully.
Regression Test success criteria: For aggregate arguments, such as structs, by design only a maximum of 3 members are promoted (DEFAULT case). However by introducing a custom OPT flag, we can set this number to different values to promote any number of an aggregate's arguments. For instance, the regression test file "fourmember-struct-promote-xxx.ll" has a four member struct passed by reference to a simple function that sums the values of the members. The flag '-numargspromoted' value has to be 0 or 4 or higher for all the 4 members in the struct to be promoted. '0' defaults to 'always promote'. Supplying a value less than th number of members in the aggregate (in this case 4) halts promotion. The regression tests are designed to PASS when the FILECHECK tool pattern matches against an output that reflects all members have been promoted to "by value".

RESULTS:

  • fourmember-struct-promote-ZERO and fourmember-struct-promote-INTMAX pass.
  • fourmember-struct-promote-DEFAULT fails, as we allow only 3 members to be promoted whereas the struct has 4 members.

Therefore, we conclude that the -numargspromoted user flag works correctly.

Now that we have this flag working correctly, we can test out the impact of the argument promotion of aggregates on compile time and run time performance.

Diff Detail

Event Timeline

teamiceberg created this revision.Jul 13 2020, 10:40 PM
Herald added a project: Restricted Project. · View Herald TranscriptJul 13 2020, 10:40 PM
Herald added subscribers: llvm-commits, hiraditya. · View Herald Transcript
Harbormaster failed remote builds in B64104: Diff 277673!Jul 13 2020, 10:40 PM
teamiceberg updated this revision to Diff 277675.Jul 13 2020, 10:51 PM

Updated with comments for MaxElements global variable in ArgumentPromotion.h file

Harbormaster failed remote builds in B64105: Diff 277675!Jul 13 2020, 10:52 PM
teamiceberg edited the summary of this revision. (Show Details)Jul 13 2020, 10:56 PM
teamiceberg updated this revision to Diff 277715.Jul 14 2020, 2:02 AM
teamiceberg edited the summary of this revision. (Show Details)

Updated with LIT test files for regression tests

Harbormaster failed remote builds in B64121: Diff 277715!Jul 14 2020, 2:02 AM
teamiceberg edited the summary of this revision. (Show Details)Jul 14 2020, 2:11 AM
jdoerfert added inline comments.Jul 14 2020, 5:08 AM
llvm/lib/Transforms/IPO/ArgumentPromotion.cpp
98

Can you please update this diff to be against a proper commit of the master branch?

teamiceberg abandoned this revision.Jul 14 2020, 6:47 PM
teamiceberg marked 2 inline comments as done.

A new patch will be put in to baseline against the latest LLVM Master Commit (at least at the time of uploading this patch).

llvm/lib/Transforms/IPO/ArgumentPromotion.cpp
98

I am putting in a new diff so it can against the very latest master commit. SO I will be abandoning this patch.

Revision Contents

PathSize
llvm/
include/
llvm/
Transforms/
IPO/
4 lines
lib/
Transforms/
IPO/
10 lines
test/
Transforms/
ArgumentPromotion/
91 lines
91 lines
91 lines

Diff 277715

llvm/include/llvm/Transforms/IPO/ArgumentPromotion.h

//===- ArgumentPromotion.h - Promote by-reference arguments -----*- C++ -*-===// //===- ArgumentPromotion.h - Promote by-reference arguments -----*- C++ -*-===//
Lint: Lint
Inline Actions

clang-format not found in user's PATH; not linting file.

Lint: Lint: clang-format not found in user's PATH; not linting file.
// //
// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. // Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
// See https://llvm.org/LICENSE.txt for license information. // See https://llvm.org/LICENSE.txt for license information.
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception // SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
// //
//===----------------------------------------------------------------------===// //===----------------------------------------------------------------------===//
#ifndef LLVM_TRANSFORMS_IPO_ARGUMENTPROMOTION_H #ifndef LLVM_TRANSFORMS_IPO_ARGUMENTPROMOTION_H
#define LLVM_TRANSFORMS_IPO_ARGUMENTPROMOTION_H #define LLVM_TRANSFORMS_IPO_ARGUMENTPROMOTION_H
#include "llvm/Analysis/CGSCCPassManager.h" #include "llvm/Analysis/CGSCCPassManager.h"
#include "llvm/Analysis/LazyCallGraph.h" #include "llvm/Analysis/LazyCallGraph.h"
#include "llvm/IR/PassManager.h" #include "llvm/IR/PassManager.h"
namespace llvm { namespace llvm {
//opt flag (if supplied) populates this Global Variable in the llvm namespace. Default value is set to 3, as was exisiting before.
//This global value can be changed via user input to set the maximum number of members that can be promoted with an aggregate.
static unsigned GL_NUMPROMARGS = 3;
class TargetTransformInfo; class TargetTransformInfo;
static unsigned GL_NUMPROMARGS = 3; //opt flag (if supplied) populates this Global Variable
/// Argument promotion pass. /// Argument promotion pass.
/// ///
/// This pass walks the functions in each SCC and for each one tries to /// This pass walks the functions in each SCC and for each one tries to
/// transform it and all of its callers to replace indirect arguments with /// transform it and all of its callers to replace indirect arguments with
/// direct (by-value) arguments. /// direct (by-value) arguments.
class ArgumentPromotionPass : public PassInfoMixin<ArgumentPromotionPass> { class ArgumentPromotionPass : public PassInfoMixin<ArgumentPromotionPass> {
unsigned MaxElements; unsigned MaxElements;
Show All 21 Lines

llvm/lib/Transforms/IPO/ArgumentPromotion.cpp

//===- ArgumentPromotion.cpp - Promote by-reference arguments -------------===// //===- ArgumentPromotion.cpp - Promote by-reference arguments -------------===//
Lint: Lint
Inline Actions

clang-format not found in user's PATH; not linting file.

Lint: Lint: clang-format not found in user's PATH; not linting file.
// //
// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. // Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
// See https://llvm.org/LICENSE.txt for license information. // See https://llvm.org/LICENSE.txt for license information.
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception // SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
// //
//===----------------------------------------------------------------------===// //===----------------------------------------------------------------------===//
// //
▲ Show 20 Lines • Show All 76 Lines • ▼ Show 20 Lines
#include <string> #include <string>
#include <utility> #include <utility>
#include <vector> #include <vector>
using namespace llvm; using namespace llvm;
#define DEBUG_TYPE "argpromotion" #define DEBUG_TYPE "argpromotion"
<<<<<<< HEAD
//opt flag to capture user supplied value for GV: GL_NUMPROMARGS //opt flag to capture user supplied value for GV: GL_NUMPROMARGS
cl::opt<unsigned, true> argmax("numargspromoted", cl::desc("Specify number of args to promote"), cl::value_desc("numargs"), cl::location(llvm::GL_NUMPROMARGS)); cl::opt<unsigned, true> argmax("numargspromoted", cl::desc("Specify number of args to promote"), cl::value_desc("numargs"), cl::location(llvm::GL_NUMPROMARGS));
=======
cl::opt<unsigned, true> argmax("maxar", cl::Required, cl::desc("Specify number of args to promote"), cl::value_desc("maxargs"), cl::location(llvm::GL_MAXARGS));
>>>>>>> df0f0e791671d16f15d67c1f265b75f5a35a7624
jdoerfertUnsubmitted
Not Done
ReplyInline Actions

Can you please update this diff to be against a proper commit of the master branch?

jdoerfert: Can you please update this diff to be against a proper commit of the master branch?
teamicebergAuthorUnsubmitted
Done
ReplyInline Actions

I am putting in a new diff so it can against the very latest master commit. SO I will be abandoning this patch.

teamiceberg: I am putting in a new diff so it can against the very latest master commit. SO I will be…
STATISTIC(NumArgumentsPromoted, "Number of pointer arguments promoted"); STATISTIC(NumArgumentsPromoted, "Number of pointer arguments promoted");
STATISTIC(NumAggregatesPromoted, "Number of aggregate arguments promoted"); STATISTIC(NumAggregatesPromoted, "Number of aggregate arguments promoted");
STATISTIC(NumByValArgsPromoted, "Number of byval arguments promoted"); STATISTIC(NumByValArgsPromoted, "Number of byval arguments promoted");
STATISTIC(NumArgumentsDead, "Number of dead pointer args eliminated"); STATISTIC(NumArgumentsDead, "Number of dead pointer args eliminated");
/// A vector used to hold the indices of a single GEP instruction /// A vector used to hold the indices of a single GEP instruction
using IndicesVector = std::vector<uint64_t>; using IndicesVector = std::vector<uint64_t>;
▲ Show 20 Lines • Show All 964 Lines • ▼ Show 20 Lines
namespace { namespace {
/// ArgPromotion - The 'by reference' to 'by value' argument promotion pass. /// ArgPromotion - The 'by reference' to 'by value' argument promotion pass.
struct ArgPromotion : public CallGraphSCCPass { struct ArgPromotion : public CallGraphSCCPass {
// Pass identification, replacement for typeid // Pass identification, replacement for typeid
static char ID; static char ID;
explicit ArgPromotion(unsigned MaxElements = 3) explicit ArgPromotion(unsigned MaxElements = GL_NUMPROMARGS)
: CallGraphSCCPass(ID), MaxElements(MaxElements) { : CallGraphSCCPass(ID), MaxElements(MaxElements) {
initializeArgPromotionPass(*PassRegistry::getPassRegistry()); initializeArgPromotionPass(*PassRegistry::getPassRegistry());
} }
void getAnalysisUsage(AnalysisUsage &AU) const override { void getAnalysisUsage(AnalysisUsage &AU) const override {
AU.addRequired<AssumptionCacheTracker>(); AU.addRequired<AssumptionCacheTracker>();
AU.addRequired<TargetLibraryInfoWrapperPass>(); AU.addRequired<TargetLibraryInfoWrapperPass>();
AU.addRequired<TargetTransformInfoWrapperPass>(); AU.addRequired<TargetTransformInfoWrapperPass>();
Show All 22 Lines
INITIALIZE_PASS_DEPENDENCY(AssumptionCacheTracker) INITIALIZE_PASS_DEPENDENCY(AssumptionCacheTracker)
INITIALIZE_PASS_DEPENDENCY(CallGraphWrapperPass) INITIALIZE_PASS_DEPENDENCY(CallGraphWrapperPass)
INITIALIZE_PASS_DEPENDENCY(TargetLibraryInfoWrapperPass) INITIALIZE_PASS_DEPENDENCY(TargetLibraryInfoWrapperPass)
INITIALIZE_PASS_DEPENDENCY(TargetTransformInfoWrapperPass) INITIALIZE_PASS_DEPENDENCY(TargetTransformInfoWrapperPass)
INITIALIZE_PASS_END(ArgPromotion, "argpromotion", INITIALIZE_PASS_END(ArgPromotion, "argpromotion",
"Promote 'by reference' arguments to scalars", false, false) "Promote 'by reference' arguments to scalars", false, false)
Pass *llvm::createArgumentPromotionPass(unsigned MaxElements) { Pass *llvm::createArgumentPromotionPass(unsigned MaxElements) {
<<<<<<< HEAD
return new ArgPromotion(GL_NUMPROMARGS); return new ArgPromotion(GL_NUMPROMARGS);
=======
return new ArgPromotion(GL_MAXARGS);
>>>>>>> df0f0e791671d16f15d67c1f265b75f5a35a7624
} }
bool ArgPromotion::runOnSCC(CallGraphSCC &SCC) { bool ArgPromotion::runOnSCC(CallGraphSCC &SCC) {
if (skipSCC(SCC)) if (skipSCC(SCC))
return false; return false;
// Get the callgraph information that we need to update to reflect our // Get the callgraph information that we need to update to reflect our
// changes. // changes.
▲ Show 20 Lines • Show All 52 Lines • Show Last 20 Lines

llvm/test/Transforms/ArgumentPromotion/fourmember-struct-promote-DEFAULT.ll

  • This file was added.
; RUN: opt < %s -basic-aa -mem2reg -argpromotion -mem2reg -S | FileCheck %s
target datalayout = "e-m:o-p270:32:32-p271:32:32-p272:64:64-i64:64-f80:128-n8:16:32:64-S128"
%struct.fourmem = type { i32, i32, i32, i32 }
; Function Attrs: noinline norecurse ssp uwtable
define i32 @main() #0 {
; CHECK-LABEL: define {{[^@]+}}@main()
; CHECK-NEXT: entry:
; CHECK-NEXT: [[F:%.*]] = alloca {{.*}}
; CHECK-NEXT: {{%.*}} = getelementptr {{.*}}
; CHECK-NEXT: store {{.*}}
; CHECK-NEXT: {{%.*}} = getelementptr {{.*}}
; CHECK-NEXT: store {{.*}}
; CHECK-NEXT: {{%.*}} = getelementptr {{.*}}
; CHECK-NEXT: store {{.*}}
; CHECK-NEXT: {{%.*}} = getelementptr {{.*}}
; CHECK-NEXT: store {{.*}}
; CHECK-NEXT: [[F]].idx{{.*}} = getelementptr %struct.fourmem, %struct.fourmem* [[F]], i64 0, i32 0
; CHECK-NEXT: [[F]].idx{{.*}}.val = load i32, i32* [[F]].idx{{.*}}, align 4
; CHECK-NEXT: [[F]].idx{{.*}} = getelementptr %struct.fourmem, %struct.fourmem* [[F]], i64 0, i32 1
; CHECK-NEXT: [[F]].idx{{.*}}.val = load i32, i32* [[F]].idx{{.*}}, align 4
; CHECK-NEXT: [[F]].idx{{.*}} = getelementptr %struct.fourmem, %struct.fourmem* [[F]], i64 0, i32 2
; CHECK-NEXT: [[F]].idx{{.*}}.val = load i32, i32* [[F]].idx{{.*}}, align 4
; CHECK-NEXT: [[F]].idx{{.*}} = getelementptr %struct.fourmem, %struct.fourmem* [[F]], i64 0, i32 3
; CHECK-NEXT: [[F]].idx{{.*}}.val = load i32, i32* [[F]].idx{{.*}}, align 4
; CHECK-NEXT: %{{.*}} = call i32 @{{.*}}fourmem(i32 [[F]].idx{{.*}}.val, i32 [[F]].idx{{.*}}.val, i32 [[F]].idx{{.*}}.val, i32 [[F]].idx{{.*}}.val)
; CHECK-NEXT: ret i32 0
;
entry:
%retval = alloca i32, align 4
%four = alloca %struct.fourmem, align 4
%T = alloca i32, align 4
store i32 0, i32* %retval, align 4
%a = getelementptr inbounds %struct.fourmem, %struct.fourmem* %four, i32 0, i32 0
store i32 1, i32* %a, align 4
%b = getelementptr inbounds %struct.fourmem, %struct.fourmem* %four, i32 0, i32 1
store i32 2, i32* %b, align 4
%c = getelementptr inbounds %struct.fourmem, %struct.fourmem* %four, i32 0, i32 2
store i32 3, i32* %c, align 4
%d = getelementptr inbounds %struct.fourmem, %struct.fourmem* %four, i32 0, i32 3
store i32 4, i32* %d, align 4
%call = call i32 @_ZL6calleeP7fourmem(%struct.fourmem* %four)
store i32 %call, i32* %T, align 4
ret i32 0
}
; Function Attrs: noinline nounwind ssp uwtable
define internal i32 @_ZL6calleeP7fourmem(%struct.fourmem* %t) #1 {
; CHECK-LABEL: define {{[^@]+}}@{{.*}}fourmem
; CHECK-SAME: (i32 %t.0.{{.*}}.val, i32 %t.0.{{.*}}.val, i32 %t.0.{{.*}}.val, i32 %t.0.{{.*}}.val)
; CHECK-NEXT: entry:
; CHECK-NEXT: %add{{.*}} = add nsw i32 {{.*}}, {{.*}}
; CHECK-NEXT: %add{{.*}} = add nsw i32 {{.*}}, {{.*}}
; CHECK-NEXT: %add{{.*}} = add nsw i32 {{.*}}, {{.*}}
; CHECK-NEXT: ret i32 %{{.*}}
;
entry:
%t.addr = alloca %struct.fourmem*, align 8
%S = alloca i32, align 4
store %struct.fourmem* %t, %struct.fourmem** %t.addr, align 8
%0 = load %struct.fourmem*, %struct.fourmem** %t.addr, align 8
%a = getelementptr inbounds %struct.fourmem, %struct.fourmem* %0, i32 0, i32 0
%1 = load i32, i32* %a, align 4
%2 = load %struct.fourmem*, %struct.fourmem** %t.addr, align 8
%b = getelementptr inbounds %struct.fourmem, %struct.fourmem* %2, i32 0, i32 1
%3 = load i32, i32* %b, align 4
%add = add nsw i32 %1, %3
%4 = load %struct.fourmem*, %struct.fourmem** %t.addr, align 8
%c = getelementptr inbounds %struct.fourmem, %struct.fourmem* %4, i32 0, i32 2
%5 = load i32, i32* %c, align 4
%add1 = add nsw i32 %add, %5
%6 = load %struct.fourmem*, %struct.fourmem** %t.addr, align 8
%d = getelementptr inbounds %struct.fourmem, %struct.fourmem* %6, i32 0, i32 3
%7 = load i32, i32* %d, align 4
%add2 = add nsw i32 %add1, %7
store i32 %add2, i32* %S, align 4
%8 = load i32, i32* %S, align 4
ret i32 %8
}
attributes #0 = { noinline norecurse ssp uwtable "correctly-rounded-divide-sqrt-fp-math"="false" "disable-tail-calls"="false" "frame-pointer"="all" "less-precise-fpmad"="false" "min-legal-vector-width"="0" "no-infs-fp-math"="false" "no-jump-tables"="false" "no-nans-fp-math"="false" "no-signed-zeros-fp-math"="false" "no-trapping-math"="true" "stack-protector-buffer-size"="8" "target-cpu"="penryn" "target-features"="+cx16,+cx8,+fxsr,+mmx,+sahf,+sse,+sse2,+sse3,+sse4.1,+ssse3,+x87" "unsafe-fp-math"="false" "use-soft-float"="false" }
attributes #1 = { noinline nounwind ssp uwtable "correctly-rounded-divide-sqrt-fp-math"="false" "disable-tail-calls"="false" "frame-pointer"="all" "less-precise-fpmad"="false" "min-legal-vector-width"="0" "no-infs-fp-math"="false" "no-jump-tables"="false" "no-nans-fp-math"="false" "no-signed-zeros-fp-math"="false" "no-trapping-math"="true" "stack-protector-buffer-size"="8" "target-cpu"="penryn" "target-features"="+cx16,+cx8,+fxsr,+mmx,+sahf,+sse,+sse2,+sse3,+sse4.1,+ssse3,+x87" "unsafe-fp-math"="false" "use-soft-float"="false" }
!llvm.module.flags = !{!0, !1}
!llvm.ident = !{!2}
!0 = !{i32 1, !"wchar_size", i32 4}
!1 = !{i32 7, !"PIC Level", i32 2}
!2 = !{!"clang version 11.0.0 (https://github.com/teamiceberg/llvm-project.git 1fb9041df0182c3e582bfcb5875e6af743eab0a1)"}
No newline at end of file

llvm/test/Transforms/ArgumentPromotion/fourmember-struct-promote-INTMAX.ll

  • This file was added.
; RUN: opt < %s -basic-aa -mem2reg -argpromotion -mem2reg -numargspromoted=2147483647 -S | FileCheck %s
target datalayout = "e-m:o-p270:32:32-p271:32:32-p272:64:64-i64:64-f80:128-n8:16:32:64-S128"
%struct.fourmem = type { i32, i32, i32, i32 }
; Function Attrs: noinline norecurse ssp uwtable
define i32 @main() #0 {
; CHECK-LABEL: define {{[^@]+}}@main()
; CHECK-NEXT: entry:
; CHECK-NEXT: [[F:%.*]] = alloca {{.*}}
; CHECK-NEXT: {{%.*}} = getelementptr {{.*}}
; CHECK-NEXT: store {{.*}}
; CHECK-NEXT: {{%.*}} = getelementptr {{.*}}
; CHECK-NEXT: store {{.*}}
; CHECK-NEXT: {{%.*}} = getelementptr {{.*}}
; CHECK-NEXT: store {{.*}}
; CHECK-NEXT: {{%.*}} = getelementptr {{.*}}
; CHECK-NEXT: store {{.*}}
; CHECK-NEXT: [[F]].idx{{.*}} = getelementptr %struct.fourmem, %struct.fourmem* [[F]], i64 0, i32 0
; CHECK-NEXT: [[F]].idx{{.*}}.val = load i32, i32* [[F]].idx{{.*}}, align 4
; CHECK-NEXT: [[F]].idx{{.*}} = getelementptr %struct.fourmem, %struct.fourmem* [[F]], i64 0, i32 1
; CHECK-NEXT: [[F]].idx{{.*}}.val = load i32, i32* [[F]].idx{{.*}}, align 4
; CHECK-NEXT: [[F]].idx{{.*}} = getelementptr %struct.fourmem, %struct.fourmem* [[F]], i64 0, i32 2
; CHECK-NEXT: [[F]].idx{{.*}}.val = load i32, i32* [[F]].idx{{.*}}, align 4
; CHECK-NEXT: [[F]].idx{{.*}} = getelementptr %struct.fourmem, %struct.fourmem* [[F]], i64 0, i32 3
; CHECK-NEXT: [[F]].idx{{.*}}.val = load i32, i32* [[F]].idx{{.*}}, align 4
; CHECK-NEXT: %{{.*}} = call i32 @{{.*}}fourmem(i32 [[F]].idx{{.*}}.val, i32 [[F]].idx{{.*}}.val, i32 [[F]].idx{{.*}}.val, i32 [[F]].idx{{.*}}.val)
; CHECK-NEXT: ret i32 0
;
entry:
%retval = alloca i32, align 4
%four = alloca %struct.fourmem, align 4
%T = alloca i32, align 4
store i32 0, i32* %retval, align 4
%a = getelementptr inbounds %struct.fourmem, %struct.fourmem* %four, i32 0, i32 0
store i32 1, i32* %a, align 4
%b = getelementptr inbounds %struct.fourmem, %struct.fourmem* %four, i32 0, i32 1
store i32 2, i32* %b, align 4
%c = getelementptr inbounds %struct.fourmem, %struct.fourmem* %four, i32 0, i32 2
store i32 3, i32* %c, align 4
%d = getelementptr inbounds %struct.fourmem, %struct.fourmem* %four, i32 0, i32 3
store i32 4, i32* %d, align 4
%call = call i32 @_ZL6calleeP7fourmem(%struct.fourmem* %four)
store i32 %call, i32* %T, align 4
ret i32 0
}
; Function Attrs: noinline nounwind ssp uwtable
define internal i32 @_ZL6calleeP7fourmem(%struct.fourmem* %t) #1 {
; CHECK-LABEL: define {{[^@]+}}@{{.*}}fourmem
; CHECK-SAME: (i32 %t.0.{{.*}}.val, i32 %t.0.{{.*}}.val, i32 %t.0.{{.*}}.val, i32 %t.0.{{.*}}.val)
; CHECK-NEXT: entry:
; CHECK-NEXT: %add{{.*}} = add nsw i32 {{.*}}, {{.*}}
; CHECK-NEXT: %add{{.*}} = add nsw i32 {{.*}}, {{.*}}
; CHECK-NEXT: %add{{.*}} = add nsw i32 {{.*}}, {{.*}}
; CHECK-NEXT: ret i32 %{{.*}}
;
entry:
%t.addr = alloca %struct.fourmem*, align 8
%S = alloca i32, align 4
store %struct.fourmem* %t, %struct.fourmem** %t.addr, align 8
%0 = load %struct.fourmem*, %struct.fourmem** %t.addr, align 8
%a = getelementptr inbounds %struct.fourmem, %struct.fourmem* %0, i32 0, i32 0
%1 = load i32, i32* %a, align 4
%2 = load %struct.fourmem*, %struct.fourmem** %t.addr, align 8
%b = getelementptr inbounds %struct.fourmem, %struct.fourmem* %2, i32 0, i32 1
%3 = load i32, i32* %b, align 4
%add = add nsw i32 %1, %3
%4 = load %struct.fourmem*, %struct.fourmem** %t.addr, align 8
%c = getelementptr inbounds %struct.fourmem, %struct.fourmem* %4, i32 0, i32 2
%5 = load i32, i32* %c, align 4
%add1 = add nsw i32 %add, %5
%6 = load %struct.fourmem*, %struct.fourmem** %t.addr, align 8
%d = getelementptr inbounds %struct.fourmem, %struct.fourmem* %6, i32 0, i32 3
%7 = load i32, i32* %d, align 4
%add2 = add nsw i32 %add1, %7
store i32 %add2, i32* %S, align 4
%8 = load i32, i32* %S, align 4
ret i32 %8
}
attributes #0 = { noinline norecurse ssp uwtable "correctly-rounded-divide-sqrt-fp-math"="false" "disable-tail-calls"="false" "frame-pointer"="all" "less-precise-fpmad"="false" "min-legal-vector-width"="0" "no-infs-fp-math"="false" "no-jump-tables"="false" "no-nans-fp-math"="false" "no-signed-zeros-fp-math"="false" "no-trapping-math"="true" "stack-protector-buffer-size"="8" "target-cpu"="penryn" "target-features"="+cx16,+cx8,+fxsr,+mmx,+sahf,+sse,+sse2,+sse3,+sse4.1,+ssse3,+x87" "unsafe-fp-math"="false" "use-soft-float"="false" }
attributes #1 = { noinline nounwind ssp uwtable "correctly-rounded-divide-sqrt-fp-math"="false" "disable-tail-calls"="false" "frame-pointer"="all" "less-precise-fpmad"="false" "min-legal-vector-width"="0" "no-infs-fp-math"="false" "no-jump-tables"="false" "no-nans-fp-math"="false" "no-signed-zeros-fp-math"="false" "no-trapping-math"="true" "stack-protector-buffer-size"="8" "target-cpu"="penryn" "target-features"="+cx16,+cx8,+fxsr,+mmx,+sahf,+sse,+sse2,+sse3,+sse4.1,+ssse3,+x87" "unsafe-fp-math"="false" "use-soft-float"="false" }
!llvm.module.flags = !{!0, !1}
!llvm.ident = !{!2}
!0 = !{i32 1, !"wchar_size", i32 4}
!1 = !{i32 7, !"PIC Level", i32 2}
!2 = !{!"clang version 11.0.0 (https://github.com/teamiceberg/llvm-project.git 1fb9041df0182c3e582bfcb5875e6af743eab0a1)"}

llvm/test/Transforms/ArgumentPromotion/fourmember-struct-promote-ZERO.ll

  • This file was added.
; RUN: opt < %s -basic-aa -mem2reg -argpromotion -mem2reg -numargspromoted=0 -S | FileCheck %s
target datalayout = "e-m:o-p270:32:32-p271:32:32-p272:64:64-i64:64-f80:128-n8:16:32:64-S128"
%struct.fourmem = type { i32, i32, i32, i32 }
; Function Attrs: noinline norecurse ssp uwtable
define i32 @main() #0 {
; CHECK-LABEL: define {{[^@]+}}@main()
; CHECK-NEXT: entry:
; CHECK-NEXT: [[F:%.*]] = alloca {{.*}}
; CHECK-NEXT: {{%.*}} = getelementptr {{.*}}
; CHECK-NEXT: store {{.*}}
; CHECK-NEXT: {{%.*}} = getelementptr {{.*}}
; CHECK-NEXT: store {{.*}}
; CHECK-NEXT: {{%.*}} = getelementptr {{.*}}
; CHECK-NEXT: store {{.*}}
; CHECK-NEXT: {{%.*}} = getelementptr {{.*}}
; CHECK-NEXT: store {{.*}}
; CHECK-NEXT: [[F]].idx{{.*}} = getelementptr %struct.fourmem, %struct.fourmem* [[F]], i64 0, i32 0
; CHECK-NEXT: [[F]].idx{{.*}}.val = load i32, i32* [[F]].idx{{.*}}, align 4
; CHECK-NEXT: [[F]].idx{{.*}} = getelementptr %struct.fourmem, %struct.fourmem* [[F]], i64 0, i32 1
; CHECK-NEXT: [[F]].idx{{.*}}.val = load i32, i32* [[F]].idx{{.*}}, align 4
; CHECK-NEXT: [[F]].idx{{.*}} = getelementptr %struct.fourmem, %struct.fourmem* [[F]], i64 0, i32 2
; CHECK-NEXT: [[F]].idx{{.*}}.val = load i32, i32* [[F]].idx{{.*}}, align 4
; CHECK-NEXT: [[F]].idx{{.*}} = getelementptr %struct.fourmem, %struct.fourmem* [[F]], i64 0, i32 3
; CHECK-NEXT: [[F]].idx{{.*}}.val = load i32, i32* [[F]].idx{{.*}}, align 4
; CHECK-NEXT: %{{.*}} = call i32 @{{.*}}fourmem(i32 [[F]].idx{{.*}}.val, i32 [[F]].idx{{.*}}.val, i32 [[F]].idx{{.*}}.val, i32 [[F]].idx{{.*}}.val)
; CHECK-NEXT: ret i32 0
;
entry:
%retval = alloca i32, align 4
%four = alloca %struct.fourmem, align 4
%T = alloca i32, align 4
store i32 0, i32* %retval, align 4
%a = getelementptr inbounds %struct.fourmem, %struct.fourmem* %four, i32 0, i32 0
store i32 1, i32* %a, align 4
%b = getelementptr inbounds %struct.fourmem, %struct.fourmem* %four, i32 0, i32 1
store i32 2, i32* %b, align 4
%c = getelementptr inbounds %struct.fourmem, %struct.fourmem* %four, i32 0, i32 2
store i32 3, i32* %c, align 4
%d = getelementptr inbounds %struct.fourmem, %struct.fourmem* %four, i32 0, i32 3
store i32 4, i32* %d, align 4
%call = call i32 @_ZL6calleeP7fourmem(%struct.fourmem* %four)
store i32 %call, i32* %T, align 4
ret i32 0
}
; Function Attrs: noinline nounwind ssp uwtable
define internal i32 @_ZL6calleeP7fourmem(%struct.fourmem* %t) #1 {
; CHECK-LABEL: define {{[^@]+}}@{{.*}}fourmem
; CHECK-SAME: (i32 %t.0.{{.*}}.val, i32 %t.0.{{.*}}.val, i32 %t.0.{{.*}}.val, i32 %t.0.{{.*}}.val)
; CHECK-NEXT: entry:
; CHECK-NEXT: %add{{.*}} = add nsw i32 {{.*}}, {{.*}}
; CHECK-NEXT: %add{{.*}} = add nsw i32 {{.*}}, {{.*}}
; CHECK-NEXT: %add{{.*}} = add nsw i32 {{.*}}, {{.*}}
; CHECK-NEXT: ret i32 %{{.*}}
;
entry:
%t.addr = alloca %struct.fourmem*, align 8
%S = alloca i32, align 4
store %struct.fourmem* %t, %struct.fourmem** %t.addr, align 8
%0 = load %struct.fourmem*, %struct.fourmem** %t.addr, align 8
%a = getelementptr inbounds %struct.fourmem, %struct.fourmem* %0, i32 0, i32 0
%1 = load i32, i32* %a, align 4
%2 = load %struct.fourmem*, %struct.fourmem** %t.addr, align 8
%b = getelementptr inbounds %struct.fourmem, %struct.fourmem* %2, i32 0, i32 1
%3 = load i32, i32* %b, align 4
%add = add nsw i32 %1, %3
%4 = load %struct.fourmem*, %struct.fourmem** %t.addr, align 8
%c = getelementptr inbounds %struct.fourmem, %struct.fourmem* %4, i32 0, i32 2
%5 = load i32, i32* %c, align 4
%add1 = add nsw i32 %add, %5
%6 = load %struct.fourmem*, %struct.fourmem** %t.addr, align 8
%d = getelementptr inbounds %struct.fourmem, %struct.fourmem* %6, i32 0, i32 3
%7 = load i32, i32* %d, align 4
%add2 = add nsw i32 %add1, %7
store i32 %add2, i32* %S, align 4
%8 = load i32, i32* %S, align 4
ret i32 %8
}
attributes #0 = { noinline norecurse ssp uwtable "correctly-rounded-divide-sqrt-fp-math"="false" "disable-tail-calls"="false" "frame-pointer"="all" "less-precise-fpmad"="false" "min-legal-vector-width"="0" "no-infs-fp-math"="false" "no-jump-tables"="false" "no-nans-fp-math"="false" "no-signed-zeros-fp-math"="false" "no-trapping-math"="true" "stack-protector-buffer-size"="8" "target-cpu"="penryn" "target-features"="+cx16,+cx8,+fxsr,+mmx,+sahf,+sse,+sse2,+sse3,+sse4.1,+ssse3,+x87" "unsafe-fp-math"="false" "use-soft-float"="false" }
attributes #1 = { noinline nounwind ssp uwtable "correctly-rounded-divide-sqrt-fp-math"="false" "disable-tail-calls"="false" "frame-pointer"="all" "less-precise-fpmad"="false" "min-legal-vector-width"="0" "no-infs-fp-math"="false" "no-jump-tables"="false" "no-nans-fp-math"="false" "no-signed-zeros-fp-math"="false" "no-trapping-math"="true" "stack-protector-buffer-size"="8" "target-cpu"="penryn" "target-features"="+cx16,+cx8,+fxsr,+mmx,+sahf,+sse,+sse2,+sse3,+sse4.1,+ssse3,+x87" "unsafe-fp-math"="false" "use-soft-float"="false" }
!llvm.module.flags = !{!0, !1}
!llvm.ident = !{!2}
!0 = !{i32 1, !"wchar_size", i32 4}
!1 = !{i32 7, !"PIC Level", i32 2}
!2 = !{!"clang version 11.0.0 (https://github.com/teamiceberg/llvm-project.git 1fb9041df0182c3e582bfcb5875e6af743eab0a1)"}