This is an archive of the discontinued LLVM Phabricator instance.

Differential D83683

[ms] [llvm-ml] Restore omitted changes requested by reviewer
AbandonedPublic

Authored by epastor on Jul 13 2020, 7:48 AM.

Details

Reviewers
None
Commits
rG3aabfa280867: [ms] [llvm-ml] Restore omitted changes requested by reviewer

Diff Detail

Unit TestsFailed

TimeTest
470 mslinux > SanitizerCommon-asan-x86_64-Linux.Linux::Unknown Unit Message ("")
280 mslinux > SanitizerCommon-lsan-x86_64-Linux.Linux::Unknown Unit Message ("")
390 mslinux > SanitizerCommon-msan-x86_64-Linux.Linux::Unknown Unit Message ("")
470 mslinux > SanitizerCommon-tsan-x86_64-Linux.Linux::Unknown Unit Message ("")
330 mslinux > SanitizerCommon-ubsan-x86_64-Linux.Linux::Unknown Unit Message ("")

Event Timeline

epastor created this revision.Jul 13 2020, 7:48 AM
Herald added a project: Restricted Project. · View Herald TranscriptJul 13 2020, 7:48 AM
Herald added subscribers: llvm-commits, hiraditya. · View Herald Transcript
epastor abandoned this revision.Jul 13 2020, 7:49 AM
Harbormaster failed remote builds in B63960: Diff 277434!Jul 13 2020, 8:21 AM

Revision Contents

PathSize
llvm/
lib/
Target/
X86/
AsmParser/
2 lines
test/
tools/
llvm-ml/
3 lines

Diff 277434

llvm/lib/Target/X86/AsmParser/X86AsmParser.cpp

Show First 20 Lines • Show All 1,651 Lines • ▼ Show 20 Lines case AsmToken::Identifier: {
StringRef Identifier = Tok.getString(); StringRef Identifier = Tok.getString();
UpdateLocLex = false; UpdateLocLex = false;
// (MASM only) <TYPE> PTR operator // (MASM only) <TYPE> PTR operator
if (Parser.isParsingMasm()) { if (Parser.isParsingMasm()) {
const AsmToken &NextTok = getLexer().peekTok(); const AsmToken &NextTok = getLexer().peekTok();
if (NextTok.is(AsmToken::Identifier) && if (NextTok.is(AsmToken::Identifier) &&
NextTok.getIdentifier().equals_lower("ptr")) { NextTok.getIdentifier().equals_lower("ptr")) {
SM.onCast(Identifier); SM.onCast(Identifier);
// eat type and ptr // Eat type and PTR.
consumeToken(); consumeToken();
End = consumeToken(); End = consumeToken();
break; break;
} }
} }
// Register, or (MASM only) <register>.<field> // Register, or (MASM only) <register>.<field>
unsigned Reg; unsigned Reg;
if (Tok.is(AsmToken::Identifier)) { if (Tok.is(AsmToken::Identifier)) {
▲ Show 20 Lines • Show All 2,606 Lines • Show Last 20 Lines

llvm/test/tools/llvm-ml/struct.test

Show First 20 Lines • Show All 150 Lines • ▼ Show 20 LinesQUUX STRUCT
u DWORD ? u DWORD ?
UNION UNION
v WORD ? v WORD ?
w DWORD ? w DWORD ?
STRUCT STRUCT
x BYTE ? x BYTE ?
y BYTE ? y BYTE ?
ENDS ENDS
after_struct BYTE ?
ENDS ENDS
z DWORD ? z DWORD ?
QUUX ENDS QUUX ENDS
t9: t9:
mov eax, [ebx].QUUX.u mov eax, [ebx].QUUX.u
mov eax, [ebx].QUUX.v mov eax, [ebx].QUUX.v
mov eax, [ebx].QUUX.w mov eax, [ebx].QUUX.w
mov eax, [ebx].QUUX.x mov eax, [ebx].QUUX.x
mov eax, [ebx].QUUX.y mov eax, [ebx].QUUX.y
mov eax, [ebx].QUUX.after_struct
mov eax, [ebx].QUUX.z mov eax, [ebx].QUUX.z
; CHECK: t9: ; CHECK: t9:
; CHECK-NEXT: mov eax, dword ptr [ebx] ; CHECK-NEXT: mov eax, dword ptr [ebx]
; CHECK-NEXT: mov eax, dword ptr [ebx + 4] ; CHECK-NEXT: mov eax, dword ptr [ebx + 4]
; CHECK-NEXT: mov eax, dword ptr [ebx + 4] ; CHECK-NEXT: mov eax, dword ptr [ebx + 4]
; CHECK-NEXT: mov eax, dword ptr [ebx + 4] ; CHECK-NEXT: mov eax, dword ptr [ebx + 4]
; CHECK-NEXT: mov eax, dword ptr [ebx + 5] ; CHECK-NEXT: mov eax, dword ptr [ebx + 5]
; CHECK-NEXT: mov eax, dword ptr [ebx + 4]
; CHECK-NEXT: mov eax, dword ptr [ebx + 8] ; CHECK-NEXT: mov eax, dword ptr [ebx + 8]
t10: t10:
mov eax, FOOBAR.f mov eax, FOOBAR.f
mov eax, FOOBAR.f.h mov eax, FOOBAR.f.h
; CHECK: t10: ; CHECK: t10:
; CHECK-NEXT: mov eax, 10 ; CHECK-NEXT: mov eax, 10
Show All 11 Lines