This is an archive of the discontinued LLVM Phabricator instance.

[compiler-rt] Fix compiler warnings and runtime errors in sanitizer RT strxfrm(_l) test cases.
ClosedPublic

Authored by dokyungs on Jul 10 2020, 3:46 PM.

Details

Summary

Fixed an implicit definition warning by including <string.h>. Also fixed run-time assertions that the return value of strxfrm_l calls is less than the buffer size by increasing the size of the referenced buffer.

Diff Detail

Event Timeline

dokyungs created this revision.Jul 10 2020, 3:46 PM
Herald added a project: Restricted Project. · View Herald TranscriptJul 10 2020, 3:46 PM
Herald added subscribers: Restricted Project, dberris. · View Herald Transcript
morehouse accepted this revision.Jul 10 2020, 4:06 PM

LGTM. Thank you DK!

This revision is now accepted and ready to land.Jul 10 2020, 4:06 PM
dokyungs edited the summary of this revision. (Show Details)Jul 10 2020, 4:17 PM
This revision was automatically updated to reflect the committed changes.