This is an archive of the discontinued LLVM Phabricator instance.

Differential D83333

[PGO][PGSO] Add profile guided size optimization to LegalizeDAG.
ClosedPublic

Authored by hjyamauchi on Jul 7 2020, 11:37 AM.

Details

Reviewers
davidxl
Commits
rGf233b92f92a6: [PGO][PGSO] Add profile guided size optimization to LegalizeDAG.

Diff Detail

Event Timeline

hjyamauchi created this revision.Jul 7 2020, 11:37 AM
Herald added a project: Restricted Project. · View Herald TranscriptJul 7 2020, 11:37 AM
Herald added a subscriber: hiraditya. · View Herald Transcript
hjyamauchi added a parent revision: D83260: [PGO][PGSO] Add profile guided size optimizations to some new sites..Jul 7 2020, 11:40 AM
Harbormaster failed remote builds in B63266: Diff 276161!Jul 7 2020, 11:41 AM
davidxl accepted this revision.Jul 14 2020, 9:24 AM

looks straight forward.

This revision is now accepted and ready to land.Jul 14 2020, 9:24 AM
Closed by commit rGf233b92f92a6: [PGO][PGSO] Add profile guided size optimization to LegalizeDAG. (authored by hjyamauchi). · Explain WhyJul 15 2020, 10:23 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents

PathSize
llvm/
lib/
CodeGen/
SelectionDAG/
2 lines
test/
CodeGen/
AArch64/
35 lines

Diff 276161

llvm/lib/CodeGen/SelectionDAG/LegalizeDAG.cpp

Show First 20 Lines • Show All 3,304 Lines • ▼ Show 20 Lines if (!TLI.useSoftFloat() && TM.Options.UnsafeFPMath) {
} }
} }
break; break;
case ISD::ConstantFP: { case ISD::ConstantFP: {
ConstantFPSDNode *CFP = cast<ConstantFPSDNode>(Node); ConstantFPSDNode *CFP = cast<ConstantFPSDNode>(Node);
// Check to see if this FP immediate is already legal. // Check to see if this FP immediate is already legal.
// If this is a legal constant, turn it into a TargetConstantFP node. // If this is a legal constant, turn it into a TargetConstantFP node.
if (!TLI.isFPImmLegal(CFP->getValueAPF(), Node->getValueType(0), if (!TLI.isFPImmLegal(CFP->getValueAPF(), Node->getValueType(0),
DAG.getMachineFunction().getFunction().hasOptSize())) DAG.shouldOptForSize()))
Results.push_back(ExpandConstantFP(CFP, true)); Results.push_back(ExpandConstantFP(CFP, true));
break; break;
} }
case ISD::Constant: { case ISD::Constant: {
ConstantSDNode *CP = cast<ConstantSDNode>(Node); ConstantSDNode *CP = cast<ConstantSDNode>(Node);
Results.push_back(ExpandConstant(CP)); Results.push_back(ExpandConstant(CP));
break; break;
} }
▲ Show 20 Lines • Show All 1,551 Lines • Show Last 20 Lines

llvm/test/CodeGen/AArch64/arm64-fp-imm-size.ll

Show All 32 Lines
; CHECK: .quad 0 ; CHECK: .quad 0
define fp128 @baz() optsize { define fp128 @baz() optsize {
; CHECK: _baz: ; CHECK: _baz:
; CHECK: adrp x[[REG:[0-9]+]], lCPI3_0@PAGE ; CHECK: adrp x[[REG:[0-9]+]], lCPI3_0@PAGE
; CHECK: ldr q0, [x[[REG]], lCPI3_0@PAGEOFF] ; CHECK: ldr q0, [x[[REG]], lCPI3_0@PAGEOFF]
; CHECK-NEXT: ret ; CHECK-NEXT: ret
ret fp128 0xL00000000000000000000000000000000 ret fp128 0xL00000000000000000000000000000000
} }
; CHECK: literal8
; CHECK: .quad 0x0000001fffffffd
define double @foo2_pgso() !prof !14 {
; CHECK: _foo2_pgso:
; CHECK: adrp x[[REG:[0-9]+]], lCPI4_0@PAGE
; CHECK: ldr d0, [x[[REG]], lCPI4_0@PAGEOFF]
; CHECK-NEXT: ret
ret double 0x1FFFFFFFd1
}
define float @bar_pgso() !prof !14 {
; CHECK: _bar_pgso:
; CHECK: adrp x[[REG:[0-9]+]], lCPI5_0@PAGE
; CHECK: ldr s0, [x[[REG]], lCPI5_0@PAGEOFF]
; CHECK-NEXT: ret
ret float 0x400921FB80000000
}
!llvm.module.flags = !{!0}
!0 = !{i32 1, !"ProfileSummary", !1}
!1 = !{!2, !3, !4, !5, !6, !7, !8, !9}
!2 = !{!"ProfileFormat", !"InstrProf"}
!3 = !{!"TotalCount", i64 10000}
!4 = !{!"MaxCount", i64 10}
!5 = !{!"MaxInternalCount", i64 1}
!6 = !{!"MaxFunctionCount", i64 1000}
!7 = !{!"NumCounts", i64 3}
!8 = !{!"NumFunctions", i64 3}
!9 = !{!"DetailedSummary", !10}
!10 = !{!11, !12, !13}
!11 = !{i32 10000, i64 100, i32 1}
!12 = !{i32 999000, i64 100, i32 1}
!13 = !{i32 999999, i64 1, i32 2}
!14 = !{!"function_entry_count", i64 0}