Page MenuHomePhabricator

[docs] Fix TestSuiteGuide.md to mention scipy
ClosedPublic

Authored by russell.gallop on Jun 23 2020, 6:59 AM.

Details

Summary

https://llvm.org/docs/TestSuiteGuide.html describes how to run compare.py in llvm-test-suite:

# Make sure pandas is installed. Prepend `sudo` if necessary.
% pip install pandas
# Show a single result file:
% test-suite/utils/compare.py results.json
# Compare two result files:
% test-suite/utils/compare.py results_a.json results_b.json

Since https://reviews.llvm.org/D57828 this also requires scipy so added this to the documentation.

Diff Detail

Event Timeline

russell.gallop created this revision.Jun 23 2020, 6:59 AM
Herald added a project: Restricted Project. · View Herald TranscriptJun 23 2020, 6:59 AM
fhahn accepted this revision.Jul 15 2020, 10:47 AM

LGTM, thanks for updating the docs!

I guess it would be even better if we would provide the dependencies in a machine-readable way, e..g. https://python-packaging.readthedocs.io/en/latest/dependencies.html

Patches welcome :)

This revision is now accepted and ready to land.Jul 15 2020, 10:47 AM
This revision was automatically updated to reflect the committed changes.

LGTM, thanks for updating the docs!

I guess it would be even better if we would provide the dependencies in a machine-readable way, e..g. https://python-packaging.readthedocs.io/en/latest/dependencies.html

Patches welcome :)

Thanks for the review. I agree. This was a drive by fix. I'll consider that if I spend more time in this area.