This is an archive of the discontinued LLVM Phabricator instance.

Differential D82291

Make it possible for client code to consume CLANG_LINK_CLANG_DYLIB
ClosedPublic

Authored by serge-sans-paille on Jun 22 2020, 5:40 AM.

Details

Reviewers
tstellar
Commits
rG05c479491c1d: Make it possible for client code to consume CLANG_LINK_CLANG_DYLIB
Summary

If a client code wants to consume clang libraries, it needs to know CLANG_LINK_CLANG_DYLIB value in order to decide whether to use the DYLIB or individual components.

Diff Detail

Event Timeline

serge-sans-paille created this revision.Jun 22 2020, 5:40 AM
Herald added a subscriber: mgorny. · View Herald TranscriptJun 22 2020, 5:40 AM
tstellar accepted this revision.Jun 29 2020, 2:02 PM

LGTM.

This revision is now accepted and ready to land.Jun 29 2020, 2:02 PM
Closed by commit rG05c479491c1d: Make it possible for client code to consume CLANG_LINK_CLANG_DYLIB (authored by serge-sans-paille). · Explain WhyJun 30 2020, 6:28 AM
This revision was automatically updated to reflect the committed changes.
Herald added a project: Restricted Project. · View Herald TranscriptJun 30 2020, 6:28 AM
Herald added a subscriber: cfe-commits. · View Herald Transcript

Revision Contents

PathSize
clang/
cmake/
modules/
1 line

Diff 274453

clang/cmake/modules/ClangConfig.cmake.in

# This file allows users to call find_package(Clang) and pick up our targets. # This file allows users to call find_package(Clang) and pick up our targets.
@CLANG_CONFIG_CODE@ @CLANG_CONFIG_CODE@
find_package(LLVM REQUIRED CONFIG find_package(LLVM REQUIRED CONFIG
HINTS "@CLANG_CONFIG_LLVM_CMAKE_DIR@") HINTS "@CLANG_CONFIG_LLVM_CMAKE_DIR@")
set(CLANG_EXPORTED_TARGETS "@CLANG_EXPORTS@") set(CLANG_EXPORTED_TARGETS "@CLANG_EXPORTS@")
set(CLANG_CMAKE_DIR "@CLANG_CONFIG_CMAKE_DIR@") set(CLANG_CMAKE_DIR "@CLANG_CONFIG_CMAKE_DIR@")
set(CLANG_INCLUDE_DIRS "@CLANG_CONFIG_INCLUDE_DIRS@") set(CLANG_INCLUDE_DIRS "@CLANG_CONFIG_INCLUDE_DIRS@")
set(CLANG_LINK_CLANG_DYLIB "@CLANG_LINK_CLANG_DYLIB@")
# Provide all our library targets to users. # Provide all our library targets to users.
include("@CLANG_CONFIG_EXPORTS_FILE@") include("@CLANG_CONFIG_EXPORTS_FILE@")
# By creating clang-tablegen-targets here, subprojects that depend on Clang's # By creating clang-tablegen-targets here, subprojects that depend on Clang's
# tablegen-generated headers can always depend on this target whether building # tablegen-generated headers can always depend on this target whether building
# in-tree with Clang or not. # in-tree with Clang or not.
if(NOT TARGET clang-tablegen-targets) if(NOT TARGET clang-tablegen-targets)
add_custom_target(clang-tablegen-targets) add_custom_target(clang-tablegen-targets)
endif() endif()