Page MenuHomePhabricator

[libTooling] Delete deprecated `Stencil` combinators.
ClosedPublic

Authored by ymandel on Jun 19 2020, 11:54 AM.

Details

Summary

Deletes text() and selection() combinators, since they have been deprecated for months.

Diff Detail

Event Timeline

ymandel created this revision.Jun 19 2020, 11:54 AM
Herald added a project: Restricted Project. · View Herald TranscriptJun 19 2020, 11:54 AM
ymandel updated this revision to Diff 272157.Jun 19 2020, 12:07 PM

fix additional refs

tdl-g accepted this revision.Jun 23 2020, 10:07 AM
This revision is now accepted and ready to land.Jun 23 2020, 10:07 AM
This revision was automatically updated to reflect the committed changes.

Hi, your git commit contains extra Phabricator tags. You can drop Reviewers: Subscribers: Tags: and the text Summary: from the git commit with the following script:

arcfilter () {
        arc amend
        git log -1 --pretty=%B | awk '/Reviewers:|Subscribers:/{p=1} /Reviewed By:|Differential Revision:/{p=0} !p && !/^Summary:$/ {sub(/^Summary: /,"");print}' | git commit --amend --date=now -F -
}

Reviewed By: is considered important by some people. Please keep the tag. (I have updated my script to use --date=now (setting author date to committer date))

https://reviews.llvm.org/D80978 contains a git pre-push hook to automate this.