This is an archive of the discontinued LLVM Phabricator instance.

Migrate libc benchmark instructions to ninja.
ClosedPublic

Authored by asteinhauser on Jun 18 2020, 8:46 PM.

Details

Reviewers
sivachandra

Diff Detail

Event Timeline

asteinhauser created this revision.Jun 18 2020, 8:46 PM
Herald added a project: Restricted Project. · View Herald TranscriptJun 18 2020, 8:46 PM
sivachandra accepted this revision.Jun 18 2020, 9:42 PM
This revision is now accepted and ready to land.Jun 18 2020, 9:42 PM

For documentation only change, please add [docs] or similar to the subject.

asteinhauser closed this revision.Jun 23 2020, 11:57 PM

For documentation only change, please add [docs] or similar to the subject.

OK. I'll do the next time.

Hi, your git commit contains extra Phabricator tags. You can drop Reviewers: Subscribers: Tags: and the text Summary: from the git commit with the following script:

arcfilter () {
        arc amend
        git log -1 --pretty=%B | awk '/Reviewers:|Subscribers:/{p=1} /Reviewed By:|Differential Revision:/{p=0} !p && !/^Summary:$/ {sub(/^Summary: /,"");print}' | git commit --amend --date=now -F -
}

Reviewed By: is considered important by some people. Please keep the tag. (I have updated my script to use --date=now (setting author date to committer date))

https://reviews.llvm.org/D80978 contains a git pre-push hook to automate this.