Differential D81532

[libcxx] Add compatible with constraint tests for some shared_ptr constructors.
ClosedPublic
Actions

Authored by zoecarver on Jun 9 2020, 9:59 PM.

Details

Reviewers

ldionne

Group Reviewers

Restricted Project

Commits

rG8697d6cfa894: [libcxx] Add compatible with constraint tests for some shared_ptr constructors.

Summary

Add shared_ptr tests where the element type and pointer type aren't 'convertible' but are 'compatible'.

Responding to a comment from D81414.

Diff Detail

Repository: rG LLVM Github Monorepo

Event Timeline

zoecarver created this revision.Jun 9 2020, 9:59 PM

Herald added a project: Restricted Project. · View Herald TranscriptJun 9 2020, 9:59 PM

Herald added a reviewer: Restricted Project. · View Herald Transcript

Herald added subscribers: libcxx-commits, dexonsmith. · View Herald Transcript

Harbormaster failed remote builds in B59738: Diff 269735!Jun 9 2020, 11:06 PM

Ping. This is a NFC.

dexonsmith removed a subscriber: dexonsmith.Jun 24 2020, 3:29 PM

ldionne accepted this revision.Jul 28 2020, 5:54 AM

This revision is now accepted and ready to land.Jul 28 2020, 5:54 AM

This revision was landed with ongoing or failed builds.Aug 1 2020, 12:07 PM

Closed by commit rG8697d6cfa894: [libcxx] Add compatible with constraint tests for some shared_ptr constructors. (authored by zoecarver). · Explain Why

This revision was automatically updated to reflect the committed changes.

zoecarver added a commit: rG8697d6cfa894: [libcxx] Add compatible with constraint tests for some shared_ptr constructors..

Revision Contents
Changeset List

Path

Size

libcxx/

test/

std/

utilities/

memory/

util.smartptr/

util.smartptr.shared/

util.smartptr.shared.const/

pointer_deleter.pass.cpp

9 lines

pointer_deleter_allocator.pass.cpp

10 lines

Diff 282408

View Options

libcxx/test/std/utilities/memory/util.smartptr/util.smartptr.shared/util.smartptr.shared.const/pointer_deleter.pass.cpp