This is an archive of the discontinued LLVM Phabricator instance.

Differential D81202

Fix the roundtrip test under llvm-profdata
ClosedPublic

Authored by lxfind on Jun 4 2020, 4:26 PM.

Details

Reviewers
wmi
wenlei
Commits
rG45f58bf469a7: Fix the roundtrip test under llvm-profdata
Summary

According to the comments, we want to convert the profile into two binary formats, and then into the md5text format.
We seems to have ignored the intermediate files.
This patch uses them to complete the full roundtrips.

Diff Detail

Event Timeline

lxfind created this revision.Jun 4 2020, 4:26 PM
Herald added a project: Restricted Project. · View Herald TranscriptJun 4 2020, 4:26 PM
Herald added a subscriber: llvm-commits. · View Herald Transcript
wmi accepted this revision.Jun 4 2020, 5:11 PM

Thanks for catching the mistake!

This revision is now accepted and ready to land.Jun 4 2020, 5:11 PM
Harbormaster completed remote builds in B59164: Diff 268620.Jun 4 2020, 5:41 PM
wenlei added a comment.Jun 5 2020, 8:56 AM

@lxfind thanks for the fix, I just committed the patch on your behalf.

Closed by commit rG45f58bf469a7: Fix the roundtrip test under llvm-profdata (authored by lxfind, committed by wenlei). · Explain WhyJun 5 2020, 8:56 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents

PathSize
llvm/
test/
tools/
llvm-profdata/
4 lines

Diff 268831

llvm/test/tools/llvm-profdata/roundtrip.test

Show All 14 Lines
RUN: llvm-profdata merge --sample --binary -output=%t.4.profdata %S/Inputs/sample-profile.proftext RUN: llvm-profdata merge --sample --binary -output=%t.4.profdata %S/Inputs/sample-profile.proftext
RUN: llvm-profdata merge --sample --extbinary -output=%t.5.profdata %t.4.profdata RUN: llvm-profdata merge --sample --extbinary -output=%t.5.profdata %t.4.profdata
RUN: llvm-profdata merge --sample --text -output=%t.4.proftext %t.5.profdata RUN: llvm-profdata merge --sample --text -output=%t.4.proftext %t.5.profdata
RUN: diff -b %t.4.proftext %S/Inputs/sample-profile.proftext RUN: diff -b %t.4.proftext %S/Inputs/sample-profile.proftext
# Trip from text --> extbinary --> md5text # Trip from text --> extbinary --> md5text
# Trip from text --> compbinary --> md5text # Trip from text --> compbinary --> md5text
# Compare the two md5 texts # Compare the two md5 texts
RUN: llvm-profdata merge --sample --compbinary -output=%t.6.profdata %S/Inputs/sample-profile.proftext RUN: llvm-profdata merge --sample --compbinary -output=%t.6.profdata %S/Inputs/sample-profile.proftext
RUN: llvm-profdata merge --sample --text -output=%t.6.proftext %S/Inputs/sample-profile.proftext RUN: llvm-profdata merge --sample --text -output=%t.6.proftext %t.6.profdata
RUN: llvm-profdata merge --sample --extbinary -use-md5 -output=%t.7.profdata %S/Inputs/sample-profile.proftext RUN: llvm-profdata merge --sample --extbinary -use-md5 -output=%t.7.profdata %S/Inputs/sample-profile.proftext
RUN: llvm-profdata merge --sample --text -output=%t.7.proftext %S/Inputs/sample-profile.proftext RUN: llvm-profdata merge --sample --text -output=%t.7.proftext %t.7.profdata
RUN: diff -b %t.6.proftext %t.7.proftext RUN: diff -b %t.6.proftext %t.7.proftext