[lldb] Fix sizeof() in Scalar::operator=()

[miko]

Summary

In Scalar::operator=(long long) the size of the result was calculated using sizeof(long) instead of sizeof(long long). On Windows sizeof(long)==4 but sizeof(long long)==8.

[labath]

The fix looks obviously correct, but could you please also add a unit test for this. I guess this would manifest itself as the inability to roundtrip e.g. std::numeric_limits<long long>::max() to a Scalar and back.

It's not required, but if you're interested, it would be nice to change all of these assignment operators to do return *this = Scalar(v);. That would remove this class of bugs (constructor/operator= inconsistencies) completely.

[teemperor]

Could you add a unit test for this? See the`ScalarTest.cpp` for the other Scalar tests.
Beside that this LGTM.

[miko]

Unittest added in https://reviews.llvm.org/D80995.

lldb/source/Utility/Scalar.cpp

 //===-- Scalar.cpp --------------------------------------------------------===//
 //
 // Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
 // See https://llvm.org/LICENSE.txt for license information.
 // SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
 //
 //===----------------------------------------------------------------------===//
 

 Scalar &Scalar::operator=(unsigned long v) {
   m_type = e_ulong;
   m_integer = llvm::APInt(sizeof(long) * 8, v);
   return *this;
 }
 
 Scalar &Scalar::operator=(long long v) {
   m_type = e_slonglong;
-  m_integer = llvm::APInt(sizeof(long) * 8, v, true);
+  m_integer = llvm::APInt(sizeof(long long) * 8, v, true);
   return *this;
 }
 
 Scalar &Scalar::operator=(unsigned long long v) {
   m_type = e_ulonglong;
   m_integer = llvm::APInt(sizeof(long long) * 8, v);
   return *this;
 }