This is an archive of the discontinued LLVM Phabricator instance.

Differential D80595

Also cache negative results in GetXcodeSDKPath (NFC)
ClosedPublic

Authored by aprantl on May 26 2020, 3:42 PM.

Details

Reviewers
JDevlieghere
friss
Commits
rGd51be1dabb8c: Also cache negative results in GetXcodeSDKPath (NFC)
rG334552150770: Also cache negative results in GetXcodeSDKPath (NFC)
Summary

This fixes a performance issue in the failure case.




rdar://63547920
Diff Detail
Event Timeline
aprantl created this revision.May 26 2020, 3:42 PM
JDevlieghere accepted this revision.May 27 2020, 11:24 AM
This revision is now accepted and ready to land.May 27 2020, 11:24 AM
Closed by commit rG334552150770: Also cache negative results in GetXcodeSDKPath (NFC) (authored by aprantl).  ·  Explain WhyMay 27 2020, 12:30 PM
This revision was automatically updated to reflect the committed changes.
Herald added a project: Restricted Project.  ·  View Herald TranscriptMay 27 2020, 12:31 PM
Revision Contents
PathSize
lldb/
source/
Host/
macosx/
objcxx/
8 lines
Diff 266359
lldb/source/Host/macosx/objcxx/HostInfoMacOSX.mm
Context not available.
  static std::mutex g_sdk_path_mutex;
  static std::mutex g_sdk_path_mutex;




  std::lock_guard<std::mutex> guard(g_sdk_path_mutex);
  std::lock_guard<std::mutex> guard(g_sdk_path_mutex);

  std::string &path = g_sdk_path[sdk.GetString()];
  auto it = g_sdk_path.find(sdk.GetString());

  if (path.empty())
  if (it != g_sdk_path.end())

    path = GetXcodeSDK(sdk);
    return it->second;

  std::string path = GetXcodeSDK(sdk);

  g_sdk_path.insert({sdk.GetString(), path});

  return path;
  return path;

}
}

Context not available.