This is an archive of the discontinued LLVM Phabricator instance.

Fixing the build command for benchmarks.
ClosedPublic

Authored by asteinhauser on May 24 2020, 12:58 PM.

Details

Summary

Building libc without clang fails with:
CMake Error at /home/asteinhauser/llvm-project/libc/CMakeLists.txt:49 (message):
'clang' and 'clang-tools-extra' are required in LLVM_ENABLE_PROJECTS to
lint llvm-libc. The linting step performs important checks to help prevent
the introduction of subtle bugs, but it may increase build times.

Diff Detail

Event Timeline

asteinhauser created this revision.May 24 2020, 12:58 PM
asteinhauser changed the visibility from "Public (No Login Required)" to "No One".May 24 2020, 1:12 PM
asteinhauser changed the visibility from "No One" to "Public (No Login Required)".
sivachandra accepted this revision.May 24 2020, 9:28 PM
This revision is now accepted and ready to land.May 24 2020, 9:28 PM
This revision was automatically updated to reflect the committed changes.
Herald added a project: Restricted Project. · View Herald TranscriptMay 28 2020, 11:34 AM

FWIW, we should do something about clang and clang-tools-extra being required. It also causes the Harbormaster builds to fail because it not longer builds all top level targets anymore.

FWIW, we should do something about clang and clang-tools-extra being required. It also causes the Harbormaster builds to fail because it not longer builds all top level targets anymore.

The premerge failures were fixed with this: https://github.com/google/llvm-premerge-checks/commit/856ce4b148c19803172abde90c8c1e53673acd4d.
The latest set of failures seem to be because the premerge service is down. Are you seeing problems elsewhere?

PaulkaToast added a subscriber: PaulkaToast.EditedMay 28 2020, 1:21 PM

FWIW, we should do something about clang and clang-tools-extra being required. It also causes the Harbormaster builds to fail because it not longer builds all top level targets anymore.

If I'm not mistaken, Is this what you are referring to?

https://github.com/google/llvm-premerge-checks/commit/856ce4b148c19803172abde90c8c1e53673acd4d#diff-d6c5855a62cf32a4dadbc2831f0f295f

Oh yes you two are right last I looked must have been before that change. Sorry for the noise.