Page MenuHomePhabricator

[libcxx] Fix deprecation warning by suppressing deprecated around __test_has_construct
ClosedPublic

Authored by zoecarver on May 23 2020, 2:28 PM.

Details

Summary

In C++17 some tests started failing after a521532aa16df2c06c91488f2a4e787586f0a611. This fixes those errors by suppressing the deprecation warning when calling construct in __test_has_construct. This is the same solution as __has_destroy_test already uses.

Diff Detail

Event Timeline

zoecarver created this revision.May 23 2020, 2:28 PM
Herald added a project: Restricted Project. · View Herald TranscriptMay 23 2020, 2:28 PM
Herald added a reviewer: Restricted Project. · View Herald Transcript
zoecarver retitled this revision from [libcxx] Suppress deprecated for __test_has_construct to [libcxx] Fix deprecation warning by suppressing deprecated around __test_has_construct.May 23 2020, 2:30 PM
zoecarver edited the summary of this revision. (Show Details)

I'm going to commit this to fix the bots. If it would be better to revert both commits, let me know and I'll do that instead.

This revision was not accepted when it landed; it landed in state Needs Review.May 23 2020, 2:51 PM
This revision was automatically updated to reflect the committed changes.

Post-commit: this LGTM, thanks for fixing.