This is an archive of the discontinued LLVM Phabricator instance.

[lldb][NFC] Overload raw_ostream operator << for ConstString
ClosedPublic

Authored by teemperor on May 20 2020, 10:05 AM.

Details

Summary

We are not doing this very often, but sometimes it's convenient when I can just << ConstStrings into llvm::errs() during testing.

Diff Detail

Event Timeline

teemperor created this revision.May 20 2020, 10:05 AM
JDevlieghere accepted this revision.May 20 2020, 10:50 AM

Makes sense

This revision is now accepted and ready to land.May 20 2020, 10:50 AM
labath accepted this revision.May 20 2020, 11:35 PM

As we start using raw_ostreams more, we'll probably also want to do this more often. So, lgtm.

lldb/include/lldb/Utility/ConstString.h
495

I believe a decision was made a while back to pass around ConstStrings as values.

This revision was automatically updated to reflect the committed changes.
Herald added a project: Restricted Project. · View Herald TranscriptMay 22 2020, 2:25 AM