[lldb][NFC] Overload raw_ostream operator << for ConstString

[teemperor]

Summary

We are not doing this very often, but sometimes it's convenient when I can just << ConstStrings into llvm::errs() during testing.

[JDevlieghere]

Makes sense

[labath]

As we start using raw_ostreams more, we'll probably also want to do this more often. So, lgtm.

lldb/include/lldb/Utility/ConstString.h

495

I believe a decision was made a while back to pass around ConstStrings as values.

lldb/include/lldb/Utility/ConstString.h

 
 namespace yaml {
 template <> struct ScalarTraits<lldb_private::ConstString> {
   static void output(const lldb_private::ConstString &, void *, raw_ostream &);
   static StringRef input(StringRef, void *, lldb_private::ConstString &);
   static QuotingType mustQuote(StringRef S) { return QuotingType::Double; }
 };
 } // namespace yaml
+
+inline raw_ostream &operator<<(raw_ostream &os, lldb_private::ConstString s) {
+  os << s.GetStringRef();
+  return os;
+}
 } // namespace llvm
 
 LLVM_YAML_IS_SEQUENCE_VECTOR(lldb_private::ConstString)
 
 #endif // LLDB_UTILITY_CONSTSTRING_H

lldb/source/Core/Section.cpp

if (m_obj_file) {
       const FileSpec &file_spec = m_obj_file->GetFileSpec();
       name = file_spec.GetFilename().AsCString();
     }
     if ((!name || !name[0]) && module_sp)
       name = module_sp->GetFileSpec().GetFilename().AsCString();
     if (name && name[0])
       s << name << '.';
   }
-  s << m_name.GetStringRef();
+  s << m_name;
 }
 
 bool Section::IsDescendant(const Section *section) {
   if (this == section)
     return true;
   SectionSP parent_sp(GetParent());
   if (parent_sp)
     return parent_sp->IsDescendant(section);

lldb/source/Symbol/Function.cpp

 
 void Function::GetDescription(Stream *s, lldb::DescriptionLevel level,
                               Target *target) {
   ConstString name = GetName();
   ConstString mangled = m_mangled.GetMangledName();
 
   *s << "id = " << (const UserID &)*this;
   if (name)
-    *s << ", name = \"" << name.GetCString() << '"';
+    s->AsRawOstream() << ", name = \"" << name << '"';
   if (mangled)
-    *s << ", mangled = \"" << mangled.GetCString() << '"';
+    s->AsRawOstream() << ", mangled = \"" << mangled << '"';
   *s << ", range = ";
   Address::DumpStyle fallback_style;
   if (level == eDescriptionLevelVerbose)
     fallback_style = Address::DumpStyleModuleWithFileAddress;
   else
     fallback_style = Address::DumpStyleFileAddress;
   GetAddressRange().Dump(s, target, Address::DumpStyleLoadAddress,
                          fallback_style);