This is an archive of the discontinued LLVM Phabricator instance.

Differential D79980

[PS4] Enable relaxed relocations by default
ClosedPublic

Authored by bd1976llvm on May 14 2020, 7:10 PM.

Details

Reviewers
probinson
Commits
rG9d23b5025d5f: [PS4] Enable relaxed relocations by default
Summary

PS4 supports these relocations types; so, we want to enable them by default.

Diff Detail

Event Timeline

bd1976llvm created this revision.May 14 2020, 7:10 PM
probinson accepted this revision.May 18 2020, 6:42 AM

LGTM

This revision is now accepted and ready to land.May 18 2020, 6:42 AM
Closed by commit rG9d23b5025d5f: [PS4] Enable relaxed relocations by default (authored by Ben Dunbobbin <Ben_Dunbobbin@sn.scee.net>). · Explain WhyMay 21 2020, 3:13 PM
This revision was automatically updated to reflect the committed changes.
Herald added a project: Restricted Project. · View Herald TranscriptMay 21 2020, 3:13 PM
Herald added a subscriber: cfe-commits. · View Herald Transcript

Revision Contents

PathSize
clang/
lib/
Driver/
ToolChains/
2 lines
test/
Driver/
18 lines

Diff 264142

clang/lib/Driver/ToolChains/PS4CPU.h

Show First 20 Lines • Show All 95 Lines • ▼ Show 20 Linespublic:
llvm::DenormalMode getDefaultDenormalModeForType( llvm::DenormalMode getDefaultDenormalModeForType(
const llvm::opt::ArgList &DriverArgs, const llvm::opt::ArgList &DriverArgs,
Action::OffloadKind DeviceOffloadKind, Action::OffloadKind DeviceOffloadKind,
const llvm::fltSemantics *FPType) const override { const llvm::fltSemantics *FPType) const override {
// DAZ and FTZ are on by default. // DAZ and FTZ are on by default.
return llvm::DenormalMode::getPreserveSign(); return llvm::DenormalMode::getPreserveSign();
} }
bool useRelaxRelocations() const override { return true; }
protected: protected:
Tool *buildAssembler() const override; Tool *buildAssembler() const override;
Tool *buildLinker() const override; Tool *buildLinker() const override;
}; };
} // end namespace toolchains } // end namespace toolchains
} // end namespace driver } // end namespace driver
} // end namespace clang } // end namespace clang
#endif // LLVM_CLANG_LIB_DRIVER_TOOLCHAINS_PS4CPU_H #endif // LLVM_CLANG_LIB_DRIVER_TOOLCHAINS_PS4CPU_H

clang/test/Driver/ps4-relax-relocations.c

  • This file was added.
// REQUIRES: x86-registered-target
// RUN: %clang -### -target x86_64-scei-ps4 %s -o - 2>&1 | \
// RUN: FileCheck %s
// RUN: %clang -### -target x86_64-scei-ps4 -Wa,-mrelax-relocations=yes %s -o - 2>&1 | \
// RUN: FileCheck %s
// RUN: %clang -### -target x86_64-scei-ps4 -Wa,-mrelax-relocations=no %s -o - 2>&1 | \
// RUN: FileCheck -check-prefix=UNSET %s
// RUN: %clang -### -x assembler -target x86_64-scei-ps4 %s -o - 2>&1 | \
// RUN: FileCheck %s
// RUN: %clang -### -x assembler -target x86_64-scei-ps4 -Wa,-mrelax-relocations=yes %s -o - 2>&1 | \
// RUN: FileCheck %s
// RUN: %clang -### -x assembler -target x86_64-scei-ps4 -Wa,-mrelax-relocations=no %s -o - 2>&1 | \
// RUN: FileCheck -check-prefix=UNSET %s
// CHECK: "--mrelax-relocations"
// UNSET-NOT: "--mrelax-relocations"