This is an archive of the discontinued LLVM Phabricator instance.

[zorg] add llgo builder, osuosl config
ClosedPublic

Authored by axw on Mar 1 2015, 6:03 PM.

Details

Summary

Add LLGoBuilder to zorg, and add base
changes to osuosl buildbot config. There are
no slaves set up yet.

Builds fail currently, pending fixes to llgo:
D7851, D7852.

Diff Detail

Event Timeline

axw updated this revision to Diff 20971.Mar 1 2015, 6:03 PM
axw retitled this revision from to [zorg] add llgo builder, osuosl config.
axw updated this object.
axw edited the test plan for this revision. (Show Details)
axw added a subscriber: Unknown Object (MLST).
pcc added a subscriber: pcc.Mar 2 2015, 12:46 AM

check-libgo will also fail because the tests for regexp and runtime/pprof are currently failing. Maybe we can find some way to run the tests for every package except those two to make sure we don't regress?

axw added a comment.Mar 2 2015, 5:22 AM
In D7989#132285, @pcc wrote:

check-libgo will also fail because the tests for regexp and runtime/pprof are currently failing. Maybe we can find some way to run the tests for every package except those two to make sure we don't regress?

Yes, I'll propose another change that removes those packages from TEST_PACKAGES in the libgo Makefile.

axw added a comment.Mar 5 2015, 7:15 PM
In D7989#132432, @axw wrote:
In D7989#132285, @pcc wrote:

check-libgo will also fail because the tests for regexp and runtime/pprof are currently failing. Maybe we can find some way to run the tests for every package except those two to make sure we don't regress?

Yes, I'll propose another change that removes those packages from TEST_PACKAGES in the libgo Makefile.

check-libgo now passes on trunk.

gkistanova edited edge metadata.Mar 10 2015, 7:32 PM

Thanks for working on this, Andrew!

You may want to consider clean builds as well as incremental builds supported now.
In this case, you would need to support at least a 'clean' property and add a step to remove the llvm_objdir with all the content if the property is set (by using the doStepIf param). This is not a show stopper for this patch, though.

zorg/buildbot/builders/LLGoBuilder.py
25

You import from buildbot.steps.shell, why not import SetProperty there as well?

66

Could you use NinjaCommand instead of direct invoking ShellCommand with "ninja" here and below, please?

axw updated this revision to Diff 21675.Mar 10 2015, 9:31 PM
axw edited edge metadata.

Address review comments on LLGoBuilder

  • Tidy up imports
  • Add clean build option, now default
  • Use NinjaCommand
axw added a comment.Mar 10 2015, 9:31 PM

Thanks for working on this, Andrew!

You may want to consider clean builds as well as incremental builds supported now.
In this case, you would need to support at least a 'clean' property and add a step to remove the llvm_objdir with all the content if the property is set (by using the doStepIf param). This is not a show stopper for this patch, though.

Thanks for the review, and suggestions. I've added the clean param, and defaulted it to True as in LLVMBuilder and ClangBuilder. Also removed some unnecessary imports.

zorg/buildbot/builders/LLGoBuilder.py
25

Done. (I had copied another builder.)

66

Done.

gkistanova accepted this revision.Mar 11 2015, 3:18 PM
gkistanova edited edge metadata.

Could you add a comment that this builder does not support Windows as is, please?

This revision is now accepted and ready to land.Mar 11 2015, 3:18 PM
axw closed this revision.Mar 11 2015, 7:28 PM
axw added a comment.Mar 11 2015, 7:28 PM

Could you add a comment that this builder does not support Windows as is, please?

Done, thanks!