Page MenuHomePhabricator

Do not list adb devices when a device id is given
ClosedPublic

Authored by emrekultursay on May 7 2020, 9:43 AM.

Details

Summary

On Android, this method gets called twice: first when establishing
a host-server connection, then when attaching to a process id.

Each call takes several seconds to finish (especially slower on Windows)
and eliminating the call for the typical case improves latency significantly.

Diff Detail

Event Timeline

emrekultursay created this revision.May 7 2020, 9:43 AM
Herald added a project: Restricted Project. · View Herald TranscriptMay 7 2020, 9:44 AM
labath accepted this revision.May 11 2020, 1:48 AM

Looks good.

This revision is now accepted and ready to land.May 11 2020, 1:48 AM

I don't have commit access. Can someone submit this?

This revision was automatically updated to reflect the committed changes.