Page MenuHomePhabricator

emrekultursay (Emre Kultursay)
User

Projects

User does not belong to any projects.

User Details

User Since
Jan 11 2016, 1:35 PM (254 w, 4 d)

Recent Activity

May 21 2020

emrekultursay added a comment to D79586: Do not list adb devices when a device id is given.

I don't have commit access. Can someone submit this?

May 21 2020, 10:15 AM · Restricted Project

May 18 2020

emrekultursay added a comment to D79757: Use IPv4 for Android connections.

I admit I don't fully understand the details of that CL and how it may interact with this one. However, I can say that I verified this CL with an Android device connected over IPv6.

May 18 2020, 10:47 AM · Restricted Project

May 12 2020

emrekultursay retitled D79757: Use IPv4 for Android connections from Try IPv4 before IPv6 when creating TCP connection to Use IPv4 for Android connections.
May 12 2020, 9:03 PM · Restricted Project
emrekultursay added a comment to D79757: Use IPv4 for Android connections.

...
Where do the addresses that we're connecting to come from (the user or lldb code)? If it's lldb code, maybe we could just replace the relevant "localhost" names with an explicit ipv4 loopback address?

This is great feedback, thank you! yes, it was just two places that had "localhost" hard-coded, and just by changing it to ipv4 loopback address, I achieved the same improvement. :)

May 12 2020, 9:02 PM · Restricted Project
emrekultursay updated the diff for D79757: Use IPv4 for Android connections.

Enforce IPv4 usage only in Android code, revert non-Android changes.

May 12 2020, 9:00 PM · Restricted Project

May 11 2020

emrekultursay updated the diff for D79757: Use IPv4 for Android connections.

Update commit message.

May 11 2020, 6:23 PM · Restricted Project
emrekultursay added a reviewer for D79757: Use IPv4 for Android connections: labath.
May 11 2020, 6:23 PM · Restricted Project
emrekultursay updated the summary of D79757: Use IPv4 for Android connections.
May 11 2020, 6:23 PM · Restricted Project
emrekultursay created D79757: Use IPv4 for Android connections.
May 11 2020, 5:50 PM · Restricted Project

May 7 2020

emrekultursay added a reviewer for D79586: Do not list adb devices when a device id is given: labath.
May 7 2020, 10:15 AM · Restricted Project
emrekultursay created D79586: Do not list adb devices when a device id is given.
May 7 2020, 10:14 AM · Restricted Project

Apr 9 2020

emrekultursay added a comment to D76806: Remove m_last_file_sp from SourceManager.

Thanks for noticing the test breakages Pavel. I fixed the bug, and verified that the tests you mentioned pass. PTAL.

Apr 9 2020, 2:57 PM · Restricted Project
emrekultursay updated the diff for D76806: Remove m_last_file_sp from SourceManager.

Fix broken tests.

Apr 9 2020, 2:43 PM · Restricted Project

Apr 8 2020

emrekultursay added a comment to D76806: Remove m_last_file_sp from SourceManager.

I don't have commit access, can someone with access commit all three approved CLs in this stack?

Apr 8 2020, 3:13 PM · Restricted Project

Apr 1 2020

emrekultursay updated the diff for D76806: Remove m_last_file_sp from SourceManager.

Fix missing use of GetLastFile

Apr 1 2020, 1:30 PM · Restricted Project
emrekultursay updated the diff for D76806: Remove m_last_file_sp from SourceManager.

use assertGreater instead of assertTrue(x>y)

Apr 1 2020, 10:26 AM · Restricted Project

Mar 30 2020

emrekultursay updated the diff for D76806: Remove m_last_file_sp from SourceManager.

Fix formatting.

Mar 30 2020, 11:56 AM · Restricted Project
emrekultursay updated the diff for D76806: Remove m_last_file_sp from SourceManager.

PTAL. Applied suggested changes, thanks for the review!

Mar 30 2020, 11:56 AM · Restricted Project
emrekultursay added a comment to D76805: Fix SourceManager::SourceFileCache insertion.

Ok, that makes kind of sense, though I am left wondering if we really need this feature, given that we have survived so long without noticing it is missing...

Am I understanding it correctly that without this patch, we would only cache the most recently accessed file (via m_last_file_sp member), and would always reload when switching to a new file?

Yes, without this patch, only the most recently accessed file is cached inside that member, and switching to a new file replaces that entry. I guess this was designed for optimizing the case where the user hits "next line" while staying in the same file. Yet, if a breakpoint on a different file is hit during that "next line" command, we trigger a reload (twice).

Mar 30 2020, 11:24 AM · Restricted Project

Mar 27 2020

emrekultursay updated the diff for D76806: Remove m_last_file_sp from SourceManager.

Cleanup the Python test to make it a bit more readable

Mar 27 2020, 5:39 PM · Restricted Project
emrekultursay added a comment to D76804: Add new LLDB setting: use-source-cache.

I added an end-to-end test to the entire use-source-cache feature in https://reviews.llvm.org/D76806

Mar 27 2020, 5:39 PM · Restricted Project
emrekultursay added a comment to D76806: Remove m_last_file_sp from SourceManager.

PTAL.

Mar 27 2020, 5:39 PM · Restricted Project
emrekultursay updated the diff for D76806: Remove m_last_file_sp from SourceManager.

Added test that verifies end-to-end impact of
"setting set use_source_cache false" on Windows.

Mar 27 2020, 5:05 PM · Restricted Project

Mar 26 2020

emrekultursay updated the diff for D76804: Add new LLDB setting: use-source-cache.
  • Apply code review comments from labath@
  • Wipe source cache when user sets the property to false
  • Also expose set/get methods for use-source-cache in SBDebugger
Mar 26 2020, 4:52 PM · Restricted Project
emrekultursay updated the diff for D76806: Remove m_last_file_sp from SourceManager.

Applied suggestions from labath@

Mar 26 2020, 10:18 AM · Restricted Project
emrekultursay added a comment to D76806: Remove m_last_file_sp from SourceManager.

It's not clear to me what is the user-visible effect of this. It sounds like there should be one, but I don't know what it is...

If LLDB will cache FileSP shared pointers, there should be only one place for caching, and it's the Source File Cache, which can be enabled/disabled by the user.
User-facing effect of this change can be found in bug: llvm.org/PR45310

Mar 26 2020, 10:18 AM · Restricted Project
emrekultursay updated the summary of D76806: Remove m_last_file_sp from SourceManager.
Mar 26 2020, 9:45 AM · Restricted Project
emrekultursay updated the summary of D76804: Add new LLDB setting: use-source-cache.
Mar 26 2020, 9:45 AM · Restricted Project
emrekultursay updated the summary of D76805: Fix SourceManager::SourceFileCache insertion.
Mar 26 2020, 9:45 AM · Restricted Project
emrekultursay updated the diff for D76805: Fix SourceManager::SourceFileCache insertion.

Applied labath@'s suggestions on test

Mar 26 2020, 9:45 AM · Restricted Project
emrekultursay added a comment to D76805: Fix SourceManager::SourceFileCache insertion.

Does this actually depend on the other patch? It looks like an independent fix we could commit separately.

This bug seems to have existed forever. Fixing it means we will have source file cache enabled for the first time. If it causes any unforeseen issues, I'd like users to have the ability to disable the cache, which is why I made this change depend on the other change.

Mar 26 2020, 9:45 AM · Restricted Project

Mar 25 2020

emrekultursay updated the diff for D76805: Fix SourceManager::SourceFileCache insertion.

Add unit tests for SourceManager::SourceFileCache

Mar 25 2020, 9:07 PM · Restricted Project
emrekultursay added a comment to D76804: Add new LLDB setting: use-source-cache.

I did not see any existing tests that validate setting/reading of properties. Can you point to me if you know any that exists?

Mar 25 2020, 7:30 PM · Restricted Project
emrekultursay updated the diff for D76805: Fix SourceManager::SourceFileCache insertion.

fix link warning

Mar 25 2020, 4:16 PM · Restricted Project
emrekultursay created D76804: Add new LLDB setting: use-source-cache.
Mar 25 2020, 3:11 PM · Restricted Project
emrekultursay created D76806: Remove m_last_file_sp from SourceManager.
Mar 25 2020, 3:11 PM · Restricted Project
emrekultursay abandoned D76803: Remove m_last_file_sp from SourceManager.
Mar 25 2020, 3:11 PM · Restricted Project
emrekultursay created D76805: Fix SourceManager::SourceFileCache insertion.
Mar 25 2020, 3:11 PM · Restricted Project
emrekultursay updated the diff for D76803: Remove m_last_file_sp from SourceManager.
  • Remove m_last_file_sp from SourceManager
Mar 25 2020, 3:11 PM · Restricted Project
emrekultursay updated the diff for D76803: Remove m_last_file_sp from SourceManager.

No changes

Mar 25 2020, 2:38 PM · Restricted Project
emrekultursay updated the diff for D76803: Remove m_last_file_sp from SourceManager.

Adding 3rd commit to diff

Mar 25 2020, 2:38 PM · Restricted Project
emrekultursay created D76803: Remove m_last_file_sp from SourceManager.
Mar 25 2020, 2:38 PM · Restricted Project
emrekultursay added a comment to D76736: [LLDB] Fix parsing of IPv6 host:port inside brackets.

I don't have commit access.

Mar 25 2020, 10:48 AM · Restricted Project
emrekultursay updated the diff for D76736: [LLDB] Fix parsing of IPv6 host:port inside brackets.
  • Added comments to Android-specific test cases, as suggested by labath@.
  • Reformatted lines that exceeded 80 chars.
Mar 25 2020, 10:48 AM · Restricted Project

Mar 24 2020

emrekultursay updated the diff for D76736: [LLDB] Fix parsing of IPv6 host:port inside brackets.

Added unit tests.

Mar 24 2020, 10:00 PM · Restricted Project
emrekultursay created D76736: [LLDB] Fix parsing of IPv6 host:port inside brackets.
Mar 24 2020, 3:39 PM · Restricted Project