Details
Details
- Reviewers
hans
Diff Detail
Diff Detail
- Repository
- rG LLVM Github Monorepo
Unit Tests
Unit Tests
Event Timeline
Comment Actions
Sorry, I completely missed this. lgtm
llvm/utils/release/merge-request.sh | ||
---|---|---|
161 | That's a nice improvement. I'm not sure 7 characters is long enough to be a unique hash though. Running this: $ git rev-list --all --abbrev=0 --abbrev-commit | awk '{ a[length] += 1 } END { for (len in a) print len, a[len] }' 5 8568 6 276655 7 69935 8 4939 9 294 10 21 suggests we have some commits that require 10 chararacters for the short hash to be unique. So maybe we should use 10? Hopefully that will last a while. |
That's a nice improvement.
I'm not sure 7 characters is long enough to be a unique hash though.
Running this:
suggests we have some commits that require 10 chararacters for the short hash to be unique. So maybe we should use 10? Hopefully that will last a while.