This is an archive of the discontinued LLVM Phabricator instance.

merge-request.sh: Rewrite to use git
Needs ReviewPublic

Authored by tstellar on May 6 2020, 12:31 PM.

Details

Reviewers
hans

Diff Detail

Event Timeline

tstellar created this revision.May 6 2020, 12:31 PM
Herald added a project: Restricted Project. · View Herald TranscriptMay 6 2020, 12:31 PM
hans accepted this revision.May 28 2020, 1:21 AM
hans edited reviewers, added: hans; removed: hansw.
hans added a subscriber: hans.

Sorry, I completely missed this. lgtm

llvm/utils/release/merge-request.sh
161

That's a nice improvement.

I'm not sure 7 characters is long enough to be a unique hash though.

Running this:

$ git rev-list --all --abbrev=0 --abbrev-commit |   awk '{ a[length] += 1 } END { for (len in a) print len, a[len] }'
5 8568
6 276655
7 69935
8 4939
9 294
10 21

suggests we have some commits that require 10 chararacters for the short hash to be unique. So maybe we should use 10? Hopefully that will last a while.