Page MenuHomePhabricator

Don't assert about missing profile info in createProfileWeightsForLoop
ClosedPublic

Authored by hans on May 5 2020, 6:45 AM.

Details

Summary

The compiler shouldn't crash if the profile info is slightly off. We hit this in Chromium.

Diff Detail

Event Timeline

hans created this revision.May 5 2020, 6:45 AM
thakis accepted this revision.May 5 2020, 9:11 AM

Could there be a test for this? Or is that difficult?

This revision is now accepted and ready to land.May 5 2020, 9:11 AM
hans added a comment.May 5 2020, 9:58 AM

Could there be a test for this? Or is that difficult?

I think it would be a bit of a pain, which is why I skipped it. It also wouldn't be a very interesting test, just "don't assert here", really.

Fair enough :)

This revision was automatically updated to reflect the committed changes.
Herald added a project: Restricted Project. · View Herald TranscriptMay 5 2020, 10:14 AM