This is an archive of the discontinued LLVM Phabricator instance.

Differential D79333

Response to review comments
AbandonedPublic

Authored by PeteSteinfeld on May 4 2020, 8:25 AM.

Details

Reviewers
DavidTruby
Summary

Removed an unnecessary "const" as per Tim's recommendation.

Diff Detail

Event Timeline

PeteSteinfeld created this revision.May 4 2020, 8:25 AM
Herald added a reviewer: DavidTruby. · View Herald TranscriptMay 4 2020, 8:25 AM
Herald added a project: Restricted Project. · View Herald Transcript
Herald added a subscriber: llvm-commits. · View Herald Transcript
Harbormaster failed remote builds in B55642: Diff 261830!May 4 2020, 9:05 AM
PeteSteinfeld abandoned this revision.May 4 2020, 9:21 AM

Not sure how this got to be a separate review.

Revision Contents

PathSize
flang/
include/
flang/
Evaluate/
2 lines
lib/
Evaluate/
2 lines

Diff 261830

flang/include/flang/Evaluate/check-expression.h

Show First 20 Lines • Show All 46 Lines • ▼ Show 20 Lines
// bounds and type param expressions. We need to differentiate them because // bounds and type param expressions. We need to differentiate them because
// additional checks are required for array bounds expressions in declarations // additional checks are required for array bounds expressions in declarations
// of derived type components (see C750). // of derived type components (see C750).
ENUM_CLASS(SpecificationExprContext, TYPE_PARAM, BOUND) ENUM_CLASS(SpecificationExprContext, TYPE_PARAM, BOUND)
template <typename A> template <typename A>
void CheckSpecificationExpr(const A &, parser::ContextualMessages &, void CheckSpecificationExpr(const A &, parser::ContextualMessages &,
const semantics::Scope &, const IntrinsicProcTable &, const semantics::Scope &, const IntrinsicProcTable &,
const SpecificationExprContext); SpecificationExprContext);
extern template void CheckSpecificationExpr(const Expr<SomeType> &x, extern template void CheckSpecificationExpr(const Expr<SomeType> &x,
parser::ContextualMessages &, const semantics::Scope &, parser::ContextualMessages &, const semantics::Scope &,
const IntrinsicProcTable &, const SpecificationExprContext); const IntrinsicProcTable &, const SpecificationExprContext);
extern template void CheckSpecificationExpr(const Expr<SomeInteger> &x, extern template void CheckSpecificationExpr(const Expr<SomeInteger> &x,
parser::ContextualMessages &, const semantics::Scope &, parser::ContextualMessages &, const semantics::Scope &,
const IntrinsicProcTable &, const SpecificationExprContext); const IntrinsicProcTable &, const SpecificationExprContext);
extern template void CheckSpecificationExpr(const Expr<SubscriptInteger> &x, extern template void CheckSpecificationExpr(const Expr<SubscriptInteger> &x,
parser::ContextualMessages &, const semantics::Scope &, parser::ContextualMessages &, const semantics::Scope &,
Show All 22 Lines

flang/lib/Evaluate/check-expression.cpp

Show First 20 Lines • Show All 314 Lines • ▼ Show 20 Linesprivate:
const std::set<std::string> badIntrinsicsForComponents_{ const std::set<std::string> badIntrinsicsForComponents_{
"allocated", "associated", "extends_type_of", "present", "same_type_as"}; "allocated", "associated", "extends_type_of", "present", "same_type_as"};
static bool IsProhibitedFunction(std::string name) { return false; } static bool IsProhibitedFunction(std::string name) { return false; }
}; };
template <typename A> template <typename A>
void CheckSpecificationExpr(const A &x, parser::ContextualMessages &messages, void CheckSpecificationExpr(const A &x, parser::ContextualMessages &messages,
const semantics::Scope &scope, const IntrinsicProcTable &table, const semantics::Scope &scope, const IntrinsicProcTable &table,
const SpecificationExprContext specExprContext) { SpecificationExprContext specExprContext) {
if (auto why{ if (auto why{
CheckSpecificationExprHelper{scope, table, specExprContext}(x)}) { CheckSpecificationExprHelper{scope, table, specExprContext}(x)}) {
messages.Say("Invalid specification expression: %s"_err_en_US, *why); messages.Say("Invalid specification expression: %s"_err_en_US, *why);
} }
} }
template void CheckSpecificationExpr(const Expr<SomeType> &, template void CheckSpecificationExpr(const Expr<SomeType> &,
parser::ContextualMessages &, const semantics::Scope &, parser::ContextualMessages &, const semantics::Scope &,
▲ Show 20 Lines • Show All 122 Lines • Show Last 20 Lines