This is an archive of the discontinued LLVM Phabricator instance.

lit googletest.py: Don't raise StopIteration to end generator function
ClosedPublic

Authored by hans on Apr 30 2020, 6:06 AM.

Details

Summary

The intention here seems to be to end the generator function, but with modern Python, raising StopIteration causes a runtime error (https://www.python.org/dev/peps/pep-0479/).

Diff Detail

Event Timeline

hans created this revision.Apr 30 2020, 6:06 AM
Herald added a project: Restricted Project. · View Herald TranscriptApr 30 2020, 6:06 AM
Herald added a subscriber: delcypher. · View Herald Transcript
thakis accepted this revision.Apr 30 2020, 9:01 AM

Thanks!

This revision is now accepted and ready to land.Apr 30 2020, 9:01 AM
This revision was automatically updated to reflect the committed changes.