This is an archive of the discontinued LLVM Phabricator instance.

[clang] [MinGW] Add the compiler rt libdirs to the search path
ClosedPublic

Authored by mstorsjo on Apr 29 2020, 2:39 AM.

Details

Summary

This matches what is done for MSVC in b8000c0ce84541c5b5535419234fb65ce77d6756. Since that commit, compiler rt sanitizer libraries aren't linked to with absolute path on windows, but using their basenames, requiring the libdirs to be passed to the linker.

This fixes undefined behaviour sanitizer on MinGW after b8000c0ce84541c5b5535419234fb65ce77d6756.

Not sure what would be a good test for this, as the lib/clang/<version>/lib/windows directory doesn't exist, it won't show up in tests...

Diff Detail

Event Timeline

mstorsjo created this revision.Apr 29 2020, 2:39 AM
Herald added a project: Restricted Project. · View Herald TranscriptApr 29 2020, 2:39 AM
hans accepted this revision.Apr 29 2020, 5:11 AM
This revision is now accepted and ready to land.Apr 29 2020, 5:11 AM
rnk accepted this revision.Apr 29 2020, 7:19 AM

lgtm

This revision was automatically updated to reflect the committed changes.