This is an archive of the discontinued LLVM Phabricator instance.

[LNT] Fix rm-machine error reporting
AcceptedPublic

Authored by frederik-h on Apr 22 2020, 6:18 AM.

Details

Summary

The lnt client tool crashes whenever 'rm-machine' tries to report
an error message after an attempt to remove a non-existing
machine. This is fixed by importing the "http" package instead
of the "http.client" module under the name "http".

Diff Detail

Event Timeline

frederik-h created this revision.Apr 22 2020, 6:18 AM
cmatthews accepted this revision.Apr 30 2020, 10:17 AM

Sorry, I was reviewing out of order and approved: D79183 which also has a fix for this. I like the test case though, could you commit the test case?

This revision is now accepted and ready to land.Apr 30 2020, 10:17 AM

Sorry, I was reviewing out of order and approved: D79183 which also has a fix for this. I like the test case though, could you commit the test case?

Sorry, I don't have commit access. Could you please commit it for me?