This is an archive of the discontinued LLVM Phabricator instance.

Differential D78233

[NFC] Correcting minor typo.
ClosedPublic

Authored by ncv on Apr 15 2020, 12:30 PM.

Details

Reviewers
xazax.hun
Commits
rG0b21f15e1417: [NFC] Correcting minor typo.
Summary

Hande -> Handle

Diff Detail

Event Timeline

ncv created this revision.Apr 15 2020, 12:30 PM
Herald added a project: Restricted Project. · View Herald TranscriptApr 15 2020, 12:30 PM
Herald added a subscriber: cfe-commits. · View Herald Transcript
ncv added a reviewer: xazax.hun.Apr 15 2020, 12:33 PM
Herald added a subscriber: rnkovacs. · View Herald TranscriptApr 15 2020, 12:33 PM
Harbormaster failed remote builds in B53410: Diff 257803!Apr 15 2020, 12:37 PM
xazax.hun accepted this revision.Apr 15 2020, 12:44 PM

LGTM! Thanks!

This revision is now accepted and ready to land.Apr 15 2020, 12:44 PM
Closed by commit rG0b21f15e1417: [NFC] Correcting minor typo. (authored by ncv). · Explain WhyApr 15 2020, 1:49 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents

PathSize
clang/
lib/
Sema/
4 lines

Diff 257837

clang/lib/Sema/SemaDeclAttr.cpp

  • This file is larger than 256 KB, so syntax highlighting is disabled by default.
Show First 20 Lines • Show All 6,686 Lines • ▼ Show 20 Lines if (!RetTy->isPointerType() && !RetTy->isReferenceType()) {
<< AL.getRange() << RetTy; << AL.getRange() << RetTy;
return; return;
} }
} }
handleSimpleAttribute<MSAllocatorAttr>(S, D, AL); handleSimpleAttribute<MSAllocatorAttr>(S, D, AL);
} }
static void handeAcquireHandleAttr(Sema &S, Decl *D, const ParsedAttr &AL) { static void handleAcquireHandleAttr(Sema &S, Decl *D, const ParsedAttr &AL) {
if (AL.isUsedAsTypeAttr()) if (AL.isUsedAsTypeAttr())
return; return;
// Warn if the parameter is definitely not an output parameter. // Warn if the parameter is definitely not an output parameter.
if (const auto *PVD = dyn_cast<ParmVarDecl>(D)) { if (const auto *PVD = dyn_cast<ParmVarDecl>(D)) {
if (PVD->getType()->isIntegerType()) { if (PVD->getType()->isIntegerType()) {
S.Diag(AL.getLoc(), diag::err_attribute_output_parameter) S.Diag(AL.getLoc(), diag::err_attribute_output_parameter)
<< AL.getRange(); << AL.getRange();
return; return;
▲ Show 20 Lines • Show All 664 Lines • ▼ Show 20 Lines case ParsedAttr::AT_MSAllocator:
handleMSAllocatorAttr(S, D, AL); handleMSAllocatorAttr(S, D, AL);
break; break;
case ParsedAttr::AT_ArmBuiltinAlias: case ParsedAttr::AT_ArmBuiltinAlias:
handleArmBuiltinAliasAttr(S, D, AL); handleArmBuiltinAliasAttr(S, D, AL);
break; break;
case ParsedAttr::AT_AcquireHandle: case ParsedAttr::AT_AcquireHandle:
handeAcquireHandleAttr(S, D, AL); handleAcquireHandleAttr(S, D, AL);
break; break;
case ParsedAttr::AT_ReleaseHandle: case ParsedAttr::AT_ReleaseHandle:
handleHandleAttr<ReleaseHandleAttr>(S, D, AL); handleHandleAttr<ReleaseHandleAttr>(S, D, AL);
break; break;
case ParsedAttr::AT_UseHandle: case ParsedAttr::AT_UseHandle:
handleHandleAttr<UseHandleAttr>(S, D, AL); handleHandleAttr<UseHandleAttr>(S, D, AL);
▲ Show 20 Lines • Show All 386 Lines • Show Last 20 Lines