Page MenuHomePhabricator

[OpenMP] Put old APIs back and added new _async series for backward compatibility
ClosedPublic

Authored by tianshilei1992 on Apr 9 2020, 1:18 PM.

Details

Summary

According to comments on bi-weekly meeting, this patch put back old APIs and added new _async series

Diff Detail

Event Timeline

tianshilei1992 created this revision.Apr 9 2020, 1:18 PM
Herald added a project: Restricted Project. · View Herald Transcript
tianshilei1992 edited the summary of this revision. (Show Details)Apr 9 2020, 1:20 PM
jdoerfert accepted this revision.Apr 9 2020, 3:52 PM

LGTM.

openmp/libomptarget/src/omptarget.cpp
822

I'd prefer to always call sync and it's a noop if it should be. Oh, they are optional now. OK.

This revision is now accepted and ready to land.Apr 9 2020, 3:52 PM
tianshilei1992 marked an inline comment as done.Apr 9 2020, 5:32 PM
tianshilei1992 added inline comments.
openmp/libomptarget/src/omptarget.cpp
822

Yes, basically if synchronize is nullptr, all operations will fall back to synchronous version.

tianshilei1992 closed this revision.Apr 9 2020, 7:43 PM