Page MenuHomePhabricator

[lldb/Symbol] Reimplement Symbols::FindSymbolFileInBundle to use the VFS
ClosedPublic

Authored by JDevlieghere on Apr 2 2020, 2:23 PM.

Details

Summary

This reimplements Symbols::FindSymbolFileInBundle to use the VFS-aware recursive directory iterator. This is needed for reproducer replay.

Diff Detail

Event Timeline

JDevlieghere created this revision.Apr 2 2020, 2:23 PM
labath accepted this revision.Apr 2 2020, 11:40 PM

looks fine, modulo the assert fail

lldb/source/Symbol/LocateSymbolFileMacOSX.cpp
275

this assert has side effects. that won't work in no-assert builds

This revision is now accepted and ready to land.Apr 2 2020, 11:40 PM
This revision was automatically updated to reflect the committed changes.
Herald added a project: Restricted Project. · View Herald TranscriptApr 3 2020, 9:41 AM