This is an archive of the discontinued LLVM Phabricator instance.

utils: Tweak clang-parse-diagnostics-file for modules includes
ClosedPublic

Authored by dexonsmith on Apr 2 2020, 10:30 AM.

Details

Reviewers
arphaman
Summary

Diagnostics from modules do not have a main-file listed. Tweak
clang-parse-diagnostics-file to patch this up. Previously, the call
to os.path.basename would crash.

Radar-Id: rdar://problem/59000292

Diff Detail

Event Timeline

dexonsmith created this revision.Apr 2 2020, 10:30 AM

LGTM. Looks like we don't have tests for this script, it would be nice to add some in the future, but that shouldn't block this.

arphaman accepted this revision.Apr 2 2020, 2:01 PM
This revision is now accepted and ready to land.Apr 2 2020, 2:01 PM
dexonsmith closed this revision.Apr 2 2020, 2:17 PM

LGTM.

0c85c488e2b5be54ce26c9f772e66d48a9290c51

Looks like we don't have tests for this script, it would be nice to add some in the future, but that shouldn't block this.

Yeah, we're missing tests for most of llvm/utils it seems.