[libc builder] Add custom step to run clang-tidy.

[PaulkaToast]

Summary

By running this on the buildbot, we ensure that clang-tidy rules are being enforced without having to burden developers with building all of clang.

[abrachet]

zorg/buildbot/builders/annotated/libc-linux.py

21

I think to use sanitizers we need to build compiler-rt too.

[PaulkaToast]

zorg/buildbot/builders/annotated/libc-linux.py

21

We don't build libc with the clang we compile. We compile clang-tidy because our new checks have not released yet so its not present in the system clang, unlike the sanitizes.

[sivachandra]

zorg/buildbot/builders/annotated/libc-linux.py

20

Adding clang and clang-tools-extra makes sense ...

43

But, running clang tidy should be driven by our build rules.

[sivachandra]

zorg/buildbot/builders/annotated/libc-linux.py

43

I would actually add that not all builders should run clang tidy. We should have an implementation standard checker builder which runs clang-tidy as part of building everything under llvmlibc. This builder should not run tests. This scheme will allow us to reduce builder cycle time. About how to do this, we can drive it via some CMake option: default behavior is to run clang-tidy as part of our build rules, while on all but one builder we disable implementation standard checking via the CMake option.

[PaulkaToast]

No longer needed as this is achieved with cmake rules.

zorg/buildbot/builders/annotated/libc-linux.py

 #!/usr/bin/python
 
 import os
 import subprocess
 import sys
 import traceback
 import util
 from contextlib import contextmanager
 import annotated_builder
 
 
 def main(argv):
     ap = annotated_builder.get_argument_parser()
     ap.add_argument('--asan', action='store_true', default=False)
     args = ap.parse_args(argv[1:])
 
-    extra_cmake_args = ['-DCMAKE_BUILD_TYPE=Debug']
+    source_dir = os.path.join('..', 'llvm-project')
+
+    # Cmake step
+    with step('cmake'):
+        projects = ['llvm', 'libc', 'clang', 'clang-tools-extra']
+
+        cmake_args = ['-GNinja', '-DCMAKE_BUILD_TYPE=Debug']
         if args.asan:
-        extra_cmake_args.append('-DLLVM_USE_SANITIZER=Address')
+            cmake_args.append('-DLLVM_USE_SANITIZER=Address')
+        cmake_args.append('-DLLVM_ENABLE_PROJECTS={}'.format(';'.join(projects)))
 
-    projects = ['llvm', 'libc']
-    check_targets = ['check-libc']
+        run_command(['cmake', os.path.join(source_dir, 'llvm')] + cmake_args)
 
-    builder = annotated_builder.AnnotatedBuilder()
-    builder.run_steps(projects=projects,
-                      check_targets=check_targets,
-                      extra_cmake_args=extra_cmake_args)
+    # Build and test step
+    with step('ninja: build and check'):
+        run_command(['ninja', 'check-libc'])
 
     # AOR tests step
     if not args.asan:
         with step('AOR Tests'):
-            aor_dir = os.path.join('..', 'llvm-project', 'libc', 'AOR_v20.02')
+            aor_dir = os.path.join(source_dir, 'libc', 'AOR_v20.02')
             run_command(['make', 'check'], directory=aor_dir)
 
+    # Clang-tidy step
+    with step('build clang-tidy'):
+        run_command(['ninja', 'clang-tidy'])
+    with step('run clang-tidy'):
+        tidy_glob = os.path.join(source_dir,'libc', 'src', '**', '**.cpp')
+        run_command('bin/clang-tidy ' + tidy_glob, shell=True)
+
 
 @contextmanager
 def step(step_name, halt_on_fail=True):
     util.report('@@@BUILD_STEP {}@@@'.format(step_name))
     if halt_on_fail:
         util.report('@@@HALT_ON_FAILURE@@@')
     try:
         yield
     except Exception as e:
         if isinstance(e, subprocess.CalledProcessError):
             util.report(
                 '{} exited with return code {}.'.format(e.cmd, e.returncode)
             )
         util.report('The build step threw an exception...')
         traceback.print_exc()
 
         util.report('@@@STEP_FAILURE@@@')
     finally:
         sys.stdout.flush()
 
-def run_command(cmd, directory='.'):
-    util.report_run_cmd(cmd, cwd=directory)
+def run_command(cmd, directory='.', shell=False):
+    util.report_run_cmd(cmd, cwd=directory, shell=shell)
 
 
 if __name__ == '__main__':
     sys.path.append(os.path.dirname(__file__))
     sys.exit(main(sys.argv))