Page MenuHomePhabricator

[mips] [IAS] Fix using .cpsetup with local labels (PR22518).
ClosedPublic

Authored by tomatabacu on Feb 17 2015, 3:48 AM.

Details

Summary

Parse for an MCExpr instead of an Identifier and use the symbol for relocations, not just the symbol's name.

This fixes errors when using local labels in .cpsetup (PR22518).

Diff Detail

Event Timeline

tomatabacu updated this revision to Diff 20076.Feb 17 2015, 3:48 AM
tomatabacu retitled this revision from to [mips] [IAS] Fix using .cpsetup with local labels (PR22518)..
tomatabacu updated this object.
tomatabacu edited the test plan for this revision. (Show Details)
tomatabacu added a reviewer: dsanders.
tomatabacu added a subscriber: Unknown Object (MLST).

Keep in mind that I'm still looking for a way to use .text+offset for the relocation, instead of hanging on to the $tmp0 symbol.

emaste added a subscriber: emaste.Feb 17 2015, 5:49 AM

Functional commentary, not code. This does appear to allow freebsd to build farther and avoid failures related to its use of .cpsetup.

dsanders accepted this revision.Feb 18 2015, 3:38 AM
dsanders edited edge metadata.

LGTM with a whitespace nit.

test/MC/Mips/cpsetup.s
109

Nit: Two blank lines

This revision is now accepted and ready to land.Feb 18 2015, 3:38 AM
tomatabacu updated this revision to Diff 20164.Feb 18 2015, 4:39 AM
tomatabacu edited edge metadata.

Addressed the whitespace nit.

tomatabacu closed this revision.Feb 18 2015, 5:48 AM