Page MenuHomePhabricator

[llvm-cov] Improve error message for missing profdata
ClosedPublic

Authored by efriedma on Mar 25 2020, 12:36 PM.

Details

Summary

I got a report recently that a user was having trouble interpreting the meaning of the error message. Hopefully this is more readable; produces something like the following:

error: No such file or directory: Could not read profile data.

Diff Detail

Event Timeline

efriedma created this revision.Mar 25 2020, 12:36 PM
Herald added a project: Restricted Project. · View Herald TranscriptMar 25 2020, 12:36 PM
davidxl added inline comments.
llvm/tools/llvm-cov/CodeCoverage.cpp
871

a nit : all the other messages uses '!' at the end, so keep it consistent here?

vsk accepted this revision.Mar 25 2020, 1:17 PM

Thanks, lgtm. I don't have a strong opinion on the message format -- David's suggestion sounds reasonable.

This revision is now accepted and ready to land.Mar 25 2020, 1:17 PM
This revision was automatically updated to reflect the committed changes.